Refactor issue sidebar and fix various problems by wxiaoguang · Pull Request #37045 · go-gitea/gitea

wxiaoguang · 2026-03-30T17:29:07Z

Fix various legacy problems, including:

Don't create default column when viewing an empty project
Fix layouts for Windows
Fix (partially) [Proposal] Do not autoreload page after any action in the issue management #15509
Fix (partially) Some actions (Stop Timer/Assign/Label/Milestone ... ) on issue page will make page reload and lose unsaved content, autosave draft or ajax #17705

The sidebar refactoring: it is a clear partial-reloading approach, brings better user experiences, and it makes "Multiple projects" / "Project column on issue sidebar" feature easy to be added.

Copilot

Pull request overview

Refactors the issue sidebar to support partial page reloading (avoiding full-page reloads that can lose in-progress edits) and fixes legacy project/column edge cases (not creating a default column when viewing an empty project).

Changes:

Convert issue sidebar initialization to a data-global-init/observer-driven approach so newly inserted sidebar DOM can be re-initialized automatically.
Replace sidebar-triggered full page reloads with a “partial reload” that swaps the sidebar and appends new timeline items.
Adjust project selection/meta handling to support “multiple projects” groundwork and avoid creating default columns for empty projects.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
web_src/js/features/repo-issue.ts	Ensures sidebar init is registered even when comment form isn’t present.
web_src/js/features/repo-issue-sidebar.ts	Refactors sidebar init to global-init + sidebar-scoped DOM querying.
web_src/js/features/repo-issue-sidebar-combolist.ts	Implements partial reload logic after sidebar updates (GET + DOM replacement).
templates/repo/issue/view_content/sidebar.tmpl	Adds `data-global-init` hook to sidebar container.
templates/repo/issue/new_form.tmpl	Adds `data-global-init` hook to sidebar on new issue/PR form.
templates/repo/issue/sidebar/project_list.tmpl	Switches hidden value source to `SelectedProjectIDs` (multi-project groundwork).
routers/web/repo/issue_page_meta.go	Adds project meta retrieval and multi-project fields on page metadata.
routers/web/repo/issue_new.go	Parses `project` as a comma-separated list; adapts metadata accordingly.
models/project/column.go	Adds `GetDefaultColumnWithFallback` and refactors default-column logic.
services/projects/issue.go	Uses fallback default-column retrieval; returns empty results for projects with no columns.
models/issues/issue_project.go	Removes unused `LoadIssuesFromColumn` helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

services/projects/issue.go

models/project/column.go

web_src/js/features/repo-issue-sidebar-combolist.ts

routers/web/repo/issue_page_meta.go

web_src/js/features/repo-issue-sidebar-combolist.ts

silverwind · 2026-03-30T18:31:09Z

How about also removing the branch/tag selector as previously discussed?

wxiaoguang · 2026-03-30T18:37:47Z

How about also removing the branch/tag selector as previously discussed?

No, not in this PR's scope, and there are still users saying "they really need it", although I doubt.

metiftikci

thank you for this change

web_src/js/features/repo-issue-sidebar-combolist.ts

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>

metiftikci

Spotless!

lunny · 2026-03-30T22:29:35Z

After some changes on the sidebar and then click subscribe, it will jump to another page with only subscribe button.

wxiaoguang · 2026-03-30T23:28:52Z

After some changes on the sidebar and then click subscribe, it will jump to another page with only subscribe button.

Damn htmx. -> Proposal: drop htmx #35059

Fix: bbfeee2

metiftikci · 2026-03-30T23:42:40Z

@lunny did you check the fix. i still got the same problem

btw sorry for missed that

wxiaoguang · 2026-03-30T23:44:42Z

i still got the same problem

I have checked, the problem is fixed.

How do you build your frontend assets? IIRC the new vite dev server's assets sometimes is still cached on browser side. Maybe you need to refresh to try.

metiftikci · 2026-03-30T23:50:00Z

here but feel free to ignore my comment

lunny · 2026-03-30T23:54:12Z

@lunny did you check the fix. i still got the same problem

btw sorry for missed that

Yes, I checked it. I tested it using make build.

wxiaoguang · 2026-03-31T00:34:26Z

i still got the same problem

What's your browser? If you don't change label, will there be the same problem?

wxiaoguang · 2026-03-31T00:37:50Z

Also cc @yardenshoham do you know how to debug the problem? TBH I have no idea .....

silverwind · 2026-03-31T00:53:07Z

Should just remove HTMX before touching any more functionalities it touches. I can probably task Claude on it later, should be a pretty safe refactor if e2e tests are used to cover the functionality during the migration.

wxiaoguang · 2026-03-31T01:03:43Z

i still got the same problem

What's your browser? If you don't change label, will there be the same problem?

According to your screenshot, I guess you are using Edge. Also tried, still not able to reproduce.

wxiaoguang · 2026-03-31T02:03:11Z

Since this PR is already large enough, and the "sidebar operation -> subscribe -> incorrect page" issue can't be reproduced by others, I think we can merge this as is, and let more people to help to test and figure out the root problem.

Even if there is a bug, it isn't serious, it only occurs in the rare case (sidebar operation + subscribe), won't block user's daily use (a fresh page just makes everything work again)
If there is anything seriously wrong, I will fix it in first time, including rewriting the htmx related code if needed. No need to worry.

* main: Refactor issue sidebar and fix various problems (go-gitea#37045) Add tests for pull request's content_version in API (go-gitea#37044) Enable concurrent vitest execution (go-gitea#36998) Fix theme discovery and Vite dev server in dev mode (go-gitea#37033) bump snapcraft deps (go-gitea#37039) Expose content_version for optimistic locking on issue and PR edits (go-gitea#37035)

metiftikci · 2026-03-31T06:57:27Z

FYI tested main with clean build on new codespace and can not see the problem

* origin/main: (192 commits) Fix NuGet package upload error handling (go-gitea#37074) Desaturate dark theme background colors (go-gitea#37056) Update JS dependencies and misc tweaks (go-gitea#37064) Redirect to the only OAuth2 provider when no other login methods and fix various problems (go-gitea#36901) Show workflow link (go-gitea#37070) Remove leftover `webpackChunkName` comments from codeeditor (go-gitea#37062) Update Go dependencies (go-gitea#36781) Add webhook name field to improve webhook identification (go-gitea#37025) (go-gitea#37040) Upgrade `go-git` to v5.17.2 (go-gitea#37060) Replace Monaco with CodeMirror (go-gitea#36764) Update Combine method to treat warnings as failures and adjust tests (go-gitea#37048) Raise minimum Node.js version to 22.18.0 (go-gitea#37058) Update golangci-lint to v2.11.4 (go-gitea#37059) Upgrade `golang.org/x/image` to v0.38.0 (go-gitea#37054) Increase e2e test timeouts on CI to fix flaky tests (go-gitea#37053) Refactor "org teams" page and help new users to "add member" to an org (go-gitea#37051) Refactor issue sidebar and fix various problems (go-gitea#37045) Add tests for pull request's content_version in API (go-gitea#37044) Enable concurrent vitest execution (go-gitea#36998) Fix theme discovery and Vite dev server in dev mode (go-gitea#37033) ... # Conflicts: # templates/user/dashboard/feeds.tmpl

fix

1d6b6cf

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 30, 2026

github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/frontend labels Mar 30, 2026

This was referenced Mar 30, 2026

Add project column picker to issue and pull request sidebar #37037

Open

Don't create default column when viewing project columns #34878

Closed

wxiaoguang requested a review from Copilot March 30, 2026 17:43

Copilot started reviewing on behalf of wxiaoguang March 30, 2026 17:44 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

fix

3daa952

metiftikci reviewed Mar 30, 2026

View reviewed changes

web_src/js/features/repo-issue-sidebar-combolist.ts Outdated Show resolved Hide resolved

web_src/js/features/repo-issue-sidebar-combolist.ts Show resolved Hide resolved

wxiaoguang added 3 commits March 31, 2026 03:51

Update web_src/js/features/repo-issue-sidebar-combolist.ts

e8e9f6c

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>

fix timeline item replace

e28533c

syncIssueMainContentTimelineItems and tests

998ead3

wxiaoguang force-pushed the refactor-sidebar branch 2 times, most recently from 2c1b6ea to ed2ee41 Compare March 30, 2026 20:48

github-actions bot added the modifies/docs label Mar 30, 2026

fine tune

857a02c

wxiaoguang force-pushed the refactor-sidebar branch from ed2ee41 to 857a02c Compare March 30, 2026 20:53

metiftikci approved these changes Mar 30, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 30, 2026

add htmx.process

bbfeee2

lunny approved these changes Mar 30, 2026

View reviewed changes

GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 30, 2026

GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Mar 30, 2026

Merge branch 'main' into refactor-sidebar

3179f16

wxiaoguang mentioned this pull request Mar 31, 2026

Proposal: drop htmx #35059

Open

wxiaoguang marked this pull request as draft March 31, 2026 00:42

move more legacy sidebar code

12933a8

wxiaoguang added 2 commits March 31, 2026 09:07

fix layout problems for Windows

c0a341c

fix more layouts for Windows

4caebd3

wxiaoguang changed the title ~~Refactor issue sidebar~~ Refactor issue sidebar and fix various problems Mar 31, 2026

fix more layouts for Windows and also checked for macOS

e7095e0

wxiaoguang marked this pull request as ready for review March 31, 2026 01:58

wxiaoguang merged commit 6ca5573 into go-gitea:main Mar 31, 2026
26 checks passed

GiteaBot added this to the 1.26.0 milestone Mar 31, 2026

wxiaoguang deleted the refactor-sidebar branch March 31, 2026 02:03

wxiaoguang mentioned this pull request Mar 31, 2026

fix(navbar): center header notification icon #36985

Closed

Uh oh!

Conversation

wxiaoguang commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

silverwind commented Mar 30, 2026

Uh oh!

wxiaoguang commented Mar 30, 2026

Uh oh!

metiftikci left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

metiftikci left a comment

Choose a reason for hiding this comment

Uh oh!

lunny commented Mar 30, 2026

Uh oh!

wxiaoguang commented Mar 30, 2026

Uh oh!

metiftikci commented Mar 30, 2026

Uh oh!

wxiaoguang commented Mar 30, 2026

Uh oh!

metiftikci commented Mar 30, 2026

Uh oh!

lunny commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Mar 31, 2026

Uh oh!

wxiaoguang commented Mar 31, 2026

Uh oh!

silverwind commented Mar 31, 2026

Uh oh!

wxiaoguang commented Mar 31, 2026

Uh oh!

wxiaoguang commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

metiftikci commented Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wxiaoguang commented Mar 30, 2026 •

edited

Loading

lunny commented Mar 30, 2026 •

edited

Loading

wxiaoguang commented Mar 31, 2026 •

edited

Loading