Conversation
There was a problem hiding this comment.
Can you confirm that NewAuthenticateMessage in v0.1.0 still handles DOMAIN\user format usernames correctly, or is this a known behavioral change? If the new library no longer parses the domain from the username, users who rely on that format for NTLM SMTP auth would silently break.
The function |
|
Generated by Claude Code on behalf of @bircni Notable Updates
|
| Area | Assessment |
|---|---|
| Routine bumps (crypto, net, grpc, sqlite3, redis, etc.) | Low risk, good hygiene |
go-webauthn/webauthn 0.13.4 → 0.16.1 |
Needs verification — large jump on pre-1.0 security library with no source changes |
mapstructure → go-viper/mapstructure/v2 |
Correct and expected |
| License file | Accurate |
The PR is well-formed and follows the right process (license file updated). The main open question is whether the webauthn jump was tested end-to-end, especially hardware key login/registration flows. If CI covers those paths, this is ready.
|
I'd say its good but I am not that familiar with the go reps maybe @wxiaoguang could have a look? |
|
It's better not upgrade too many dependencies in one PR. |
I won't approve this one, because there is already one: Update Go dependencies #36781 . In most cases, the early ones should have higher priority. I won't spend time on Update Go dependencies #36781, because the author "don't feel like talking against a wall", I don't want to talk to a wall either. context: #36541 (comment) , #36546 , #36618 |
If you'd like to make "constructive" reviews, you should either: show how to do it "better", or do it "better" by yourself. btw: I don't think opening dozens or even hundreds of PRs to update dependencies is better. |
1.2.31.2.40.0.0-20250502153856-5100632e89200.0.0-20260317195500-b9f38cf0d4321.19.01.21.00.0.0-20221128193559-754e69321350.1.01.3.01.4.11.11.01.12.01.19.71.19.121.33.81.33.110.25.10.25.22.9.42.9.55.7.05.8.05.16.55.17.03.4.123.4.134.15.04.16.00.13.40.16.10.10.50.10.60.0.0-20260202012954-cb029daf43ef0.0.0-20260302011040-a15ffb7f9dcc1.18.31.18.51.11.11.12.01.14.331.14.370.36.00.36.11.9.61.9.87.0.987.0.999.17.39.18.01.7.161.7.170.47.00.49.00.35.00.37.00.49.00.52.00.34.00.36.00.19.00.20.00.40.00.42.00.33.00.35.01.78.01.79.30.0.0-20191008002943-06d1c002b2510.0.0-20260301104140-add494e31dab