Conversation
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/api
wxiaoguang
force-pushed
the
update-go-dep
branch
from
4d19ab1 to
96785f7
Compare
There was a problem hiding this comment.
Pull request overview
Updates Go module dependencies and aligns code with updated upstream APIs (notably ActivityPub NaturalLanguageValues language key typing).
Changes:
- Bumped multiple Go dependencies in
go.mod/go.sum. - Updated ActivityPub person actor generation to use typed language references.
- Added
make update-gotarget and refreshed Go licenses manifest for new deps.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| routers/api/v1/activitypub/person.go | Adjusts NaturalLanguageValues.Set calls to use typed language refs after dependency updates |
| go.mod | Updates direct/indirect module versions and adds/adjusts replace directives/comments |
| go.sum | Regenerates dependency checksums for updated module graph |
| assets/go-licenses.json | Adds/removes license entries to match the updated dependency set |
| Makefile | Adds update-go target and expands update to include Go deps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Don't mark Copilot reviews as off-topic, I want to see them, even if they are crap. |
I have checked , all are wrong and off-topic |
|
Ok, just keep them resolved then in such a case. |
wxiaoguang
force-pushed
the
update-go-dep
branch
from
96785f7 to
3bd2fb4
Compare
wxiaoguang
force-pushed
the
update-go-dep
branch
from
3bd2fb4 to
a74fe51
Compare
| replace git.sr.ht/~mariusor/go-xsd-duration => gitea.com/gitea/go-xsd-duration v0.0.0-20220703122237-02e73435a078 // git.sr.ht was not stable, there is no change in the upstream package | ||
|
|
||
| exclude github.com/gofrs/uuid v4.0.0+incompatible | ||
| replace go.yaml.in/yaml/v4 => go.yaml.in/yaml/v4 v4.0.0-rc.3 // TODO: actionlint doesn't compile with yaml v4.0.0-rc.4, maybe it will be fixed when yaml reaches v4 stable |
There was a problem hiding this comment.
please file upstream issue if possible, otherwise this replace may linger longer than it needs to.
| exclude github.com/satori/go.uuid v1.2.0 | ||
| replace github.com/Azure/azure-sdk-for-go/sdk/storage/azblob => github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.6.2 // TODO: "azurite:latest" image doesn't work with latest sdk, https://github.com/Azure/Azurite/issues/2623 | ||
|
|
||
| replace github.com/urfave/cli/v3 => github.com/urfave/cli/v3 v3.4.1 // TODO: changed global-flag-parsing behiavor, breaks many tests |
There was a problem hiding this comment.
Does the module really have breaking changes in minor releases? Also typo behiavor.
| update: update-go update-js update-py ## update dependencies | ||
|
|
||
| .PHONY: update-go | ||
| update-go: ## update go dependencies |
There was a problem hiding this comment.
| update-go: ## update go dependencies | |
| update-go: ## update go dependencies |
|
This is also just a demo PR (like update go #36546) for you to show how Golang dependency works. The code compiles, and the CI passes. You can create a PR from your fork/branch. |
|
Thanks for wasting my time. Next time, label the PR as "demo" and not "ready for review". |
You have wasted far more of my time ahead. |
No description provided.