Conversation
wxiaoguang
left a comment
There was a problem hiding this comment.
It should use golang's go get -u ./...
It doesn't make sense to use a non-Golang-ecosystem update tool.
The tool is much faster than Nothing prevents you from using |
Then you can use
|
If it is "faster", then it's likely that you skipped some steps, or package downloading. The "saved" time will be repaid later. Unless you 100% reproduce Golang's behavior, or directly call "go get -u", I don't see why it can be right. |
The official approach to lock a package's version is using "replace" in go.mod |
No, nothing is skipped. go get is slow because its conservative with parallel requests and waits longer for timeouts while polling major release version. |
But that's inconsistent with js or python. |
I don't care about Golang packages should be consistent with js or python. Golang syntax isn't consistent with js or python. Golang go.mod isn't consistent with js or python. Golang toolchain commands are not consistent with js or python. I don't see why it should reinvent the wheels to manage Golang dependencies. https://en.wikipedia.org/wiki/Occam%27s_razor You can add a make target if you really need it and are going to maintain the dependencies, but I believe it can simply use |
|
I prefer one tool to manage all dependencies instead of having to deal with 5 different tools. Ultimately it will lead to me not being motivated to update go dependencies and we are already lagging behind on many. If you like to demotivate me, so do it. |
Signed-off-by: silverwind <me@silverwind.io>
I don't mean to "demotivate". At least, I think you can start using your tool to upgrade the go dependencies and prove that it really works, before introducing it without really using it. |
Signed-off-by: silverwind <me@silverwind.io>
|
I don't feel like talking against a wall. |
Me too, and I don't like fixing bugs for a wall. |
|
update go #36546 You can see there are still problems when upgrading, I don't think your tool have handled it, or it's worth to spend time to fully reinvent a And you can see upgrading blindly just fails, Golang ecosystem is not like JS ecosystem. If you think I was "demotivating", feel free to edit that PR to handle these problems to show that your tool is right. |
Add convenience command
make update-goto update all go dependencies.updatesnow fully supports handling go dependencies.