Skip to content

Fix typos and grammar in English locale#36751

Merged
silverwind merged 3 commits intogo-gitea:mainfrom
yshyuk:fix/locale-en-us-typos
Feb 27, 2026
Merged

Fix typos and grammar in English locale#36751
silverwind merged 3 commits intogo-gitea:mainfrom
yshyuk:fix/locale-en-us-typos

Conversation

@yshyuk
Copy link
Copy Markdown
Contributor

@yshyuk yshyuk commented Feb 25, 2026

Fix several English locale issues as suggested in #35015:

  • Rename enterred to entered in locale keys (form.enterred_invalid_*)
    and update all Go source references accordingly
  • Fix subject-verb agreement in oauth2_applications_desc and
    oauth2_application_create_description
  • Improve awkward phrasing in startpage.license_desc

Only locale_en-US.json is modified; other locales are managed by Crowdin.

Ref #35015

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 25, 2026
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 25, 2026
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 25, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2026
@silverwind
Copy link
Copy Markdown
Member

Some merge conflicts.

- Rename "enterred" to "entered" in locale keys and Go source files
- Fix subject-verb agreement: "enables" -> "enable", "gives" -> "give"
- Improve awkward phrasing: "Don't be shy to be a contributor" -> "Don't hesitate to contribute"

Ref go-gitea#35015

Signed-off-by: yshyuk <dbsrbtkd94@gmail.com>
@yshyuk yshyuk force-pushed the fix/locale-en-us-typos branch from bf61379 to b23f5d4 Compare February 27, 2026 13:59
@yshyuk
Copy link
Copy Markdown
Contributor Author

yshyuk commented Feb 27, 2026

@silverwind
Rebased onto latest main to resolve merge conflicts.

The conflicts were caused by #36769 (Deprecate RenderWithErr) which renamed RenderWithErr → RenderWithErrDeprecated on the same lines where this PR fixes the enterred → entered
typo. Resolution: applied both changes — using RenderWithErrDeprecated with the corrected entered spelling.

Affected files:

  • routers/web/repo/setting/setting.go (7 call sites)
  • routers/web/user/setting/account.go (1 call site)
  • options/locale/locale_en-US.json — auto-merged cleanly

@wxiaoguang wxiaoguang marked this pull request as draft February 27, 2026 14:50
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot removed the modifies/go Pull requests that update Go code label Feb 27, 2026
@silverwind silverwind marked this pull request as ready for review February 27, 2026 16:18
@silverwind silverwind enabled auto-merge (squash) February 27, 2026 16:52
@silverwind silverwind merged commit b24780b into go-gitea:main Feb 27, 2026
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Feb 27, 2026
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 2, 2026
* giteaofficial/main: (21 commits)
  Enable docker layer caching for `dry-run` and `nightly` container builds (go-gitea#36738)
  Add admin badge to navbar avatar (go-gitea#36790)
  WorkflowDispatch api optionally return runid (go-gitea#36706)
  upgrade minimatch (go-gitea#36760)
  Add `never` option to `PUBLIC_URL_DETECTION` configuration (go-gitea#36785)
  Refactor avatar package, support default avatar fallback (go-gitea#36788)
  Mark unused&immature activitypub as "not implemented" (go-gitea#36789)
  Add “Copy Source” to markup comment menu (go-gitea#36726)
  Update Nix flake (go-gitea#36787)
  Implements OIDC RP-Initiated Logout (go-gitea#36724)
  Fix README symlink resolution in subdirectories like .github (go-gitea#36775)
  [skip ci] Updated translations via Crowdin
  Correct spelling (go-gitea#36783)
  refactor: replace legacy tw-flex utility classes with flex-text-block/inline (go-gitea#36778)
  Fix `no-content` message not rendering after comment edit (go-gitea#36733)
  Fix typos and grammar in English locale (go-gitea#36751)
  Move Fomantic dropdown CSS to custom module (go-gitea#36530)
  Use "Enable Gravatar" but not "Disable" (go-gitea#36771)
  feat: add branch_count to repository API (go-gitea#35351) (go-gitea#36743)
  Deprecate RenderWithErr (go-gitea#36769)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants