Fix no-content message not rendering after comment edit#36733
Merged
lunny merged 3 commits intogo-gitea:mainfrom Feb 27, 2026
Merged
Fix no-content message not rendering after comment edit#36733lunny merged 3 commits intogo-gitea:mainfrom
no-content message not rendering after comment edit#36733lunny merged 3 commits intogo-gitea:mainfrom
Conversation
GiteaBot
added
the
lgtm/need 2
silverwind
changed the title
no-content message not rendering after comment edit
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where editing a non-empty comment/issue content to become empty would render a blank comment body instead of showing the "No content" placeholder that the server initially renders for empty content.
Changes:
- Extracted duplicate empty content handling logic into a new
commentContentHTMLhelper function - Applied this helper consistently to both issue content and comment content updates
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| routers/web/repo/issue_comment.go | Removed duplicate empty content handling code and unused imports; now calls commentContentHTML helper |
| routers/web/repo/issue.go | Added new commentContentHTML helper function; applied it to UpdateIssueContent response |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lunny
approved these changes
Feb 24, 2026
GiteaBot
added
lgtm/need 1
TheFox0x7
approved these changes
Feb 27, 2026
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 2, 2026
* giteaofficial/main: (21 commits) Enable docker layer caching for `dry-run` and `nightly` container builds (go-gitea#36738) Add admin badge to navbar avatar (go-gitea#36790) WorkflowDispatch api optionally return runid (go-gitea#36706) upgrade minimatch (go-gitea#36760) Add `never` option to `PUBLIC_URL_DETECTION` configuration (go-gitea#36785) Refactor avatar package, support default avatar fallback (go-gitea#36788) Mark unused&immature activitypub as "not implemented" (go-gitea#36789) Add “Copy Source” to markup comment menu (go-gitea#36726) Update Nix flake (go-gitea#36787) Implements OIDC RP-Initiated Logout (go-gitea#36724) Fix README symlink resolution in subdirectories like .github (go-gitea#36775) [skip ci] Updated translations via Crowdin Correct spelling (go-gitea#36783) refactor: replace legacy tw-flex utility classes with flex-text-block/inline (go-gitea#36778) Fix `no-content` message not rendering after comment edit (go-gitea#36733) Fix typos and grammar in English locale (go-gitea#36751) Move Fomantic dropdown CSS to custom module (go-gitea#36530) Use "Enable Gravatar" but not "Disable" (go-gitea#36771) feat: add branch_count to repository API (go-gitea#35351) (go-gitea#36743) Deprecate RenderWithErr (go-gitea#36769) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When non-empty comment content edited is deleted, it would render a empty comment body:
Fix it so it renders the same placeholder HTML that the server sends for empty content before edits: