Skip to content

Fix assignee sidebar links and empty placeholder after #32465 refactor#36559

Merged
wxiaoguang merged 6 commits intogo-gitea:mainfrom
tyroneyeh:main_assigneeLinkEmptyIssue
Feb 8, 2026
Merged

Fix assignee sidebar links and empty placeholder after #32465 refactor#36559
wxiaoguang merged 6 commits intogo-gitea:mainfrom
tyroneyeh:main_assigneeLinkEmptyIssue

Conversation

@tyroneyeh
Copy link
Copy Markdown
Contributor

@tyroneyeh tyroneyeh commented Feb 8, 2026 •
edited
Loading

Follow-up to #32465: Fix the assignee sidebar after the selector refactor.

Changes:

  1. Candidate assignee links now use QueryBuild to point to the correct issues/pulls list, fixing cloned dropdown items' href.
  2. Removed redundant rendering of existing assignees; $hasAssignees now controls the "no assignees" placeholder safely.

This ensures the sidebar works correctly and the empty-list placeholder is shown/hidden as expected.

Before:
image

After:
20260208_222444

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2026
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Feb 8, 2026
wxiaoguang
wxiaoguang reviewed Feb 8, 2026
View reviewed changes
wxiaoguang
wxiaoguang reviewed Feb 8, 2026
View reviewed changes
@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Feb 8, 2026

Do you really understand the problem or what you are doing?

@tyroneyeh
Copy link
Copy Markdown
Contributor Author

tyroneyeh commented Feb 8, 2026

Do you really understand the problem or what you are doing?

yes， I've added screenshots of the before and after edits.

@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Feb 8, 2026

Do you really understand the problem or what you are doing?

yes， I've added screenshots of the before and after edits.

Thank you very much, will take a look

@wxiaoguang wxiaoguang force-pushed the main_assigneeLinkEmptyIssue branch from 3f1657b to aabc264 Compare February 8, 2026 15:06
@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Feb 8, 2026

Good catch. The long story is that updateUiList won't update the list if the dropdown contains "checked" items.

So, the "labels" list still has the similar problem, but the list is just correct.

To fully fix the problem, I also made some changes to the labels list. And by the way, use "listBaseLink" for the base like, and just append ?xxx to it since we clearly know that is is a base url with no parameter.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2026
@wxiaoguang wxiaoguang added type/bug backport/v1.25 This PR should be backported to Gitea 1.25 labels Feb 8, 2026
@wxiaoguang wxiaoguang added this to the 1.26.0 milestone Feb 8, 2026
@wxiaoguang
Copy link
Copy Markdown
Contributor

wxiaoguang commented Feb 8, 2026

let's see whether the bot can automatically backport it when this fix gets merged, then no need to manually backport 😄

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2026
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 8, 2026 20:28
@wxiaoguang wxiaoguang merged commit c401cda into go-gitea:main Feb 8, 2026
24 checks passed
@tyroneyeh tyroneyeh deleted the main_assigneeLinkEmptyIssue branch February 8, 2026 23:00
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 9, 2026
@tyroneyeh @wxiaoguang @GiteaBot
Fix assignee sidebar links and empty placeholder after go-gitea#32465 …
2e6439f 
…refactor (go-gitea#36559)

Follow-up to go-gitea#32465: Fix the assignee sidebar after the selector
refactor.


Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot mentioned this pull request Feb 9, 2026
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Feb 9, 2026
wxiaoguang added a commit that referenced this pull request Feb 9, 2026
@GiteaBot @tyroneyeh @wxiaoguang
Fix assignee sidebar links and empty placeholder (#36559) (#36563)
9b3a952 
Backport #36559 by tyroneyeh

Co-authored-by: Tyrone Yeh <siryeh@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 9, 2026
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f55a8b3 
* giteaofficial/main:
  Refactor merge conan and container auth preserve actions taskID (go-gitea#36560)
  Fix assignee sidebar links and empty placeholder after go-gitea#32465 refactor (go-gitea#36559)
  Fix various version parsing problems (go-gitea#36553)
  Fix highlight diff result (go-gitea#36539)
  Refactor Nuget Auth to reuse Basic Auth Token Validation (go-gitea#36558)
  Update go dependencies (go-gitea#36548)
  Prevent navigation keys from triggering actions during IME composition (go-gitea#36540)
  Fix various mermaid bugs (go-gitea#36547)
  Add `elk` layout support to mermaid (go-gitea#36486)
  Allow configuring default PR base branch (fixes go-gitea#36412) (go-gitea#36425)
  [skip ci] Updated translations via Crowdin
  Color command/error logs in Actions log (go-gitea#36538)
  Add paging headers (go-gitea#36521)
  Fix issues filter dropdown showing empty label scope section (go-gitea#36535)
  [SECURITY] fix: Adjust the toolchain version (go-gitea#36537)
  Hide `add-matcher` and `remove-matcher` from actions job logs (go-gitea#36520)
  Improve timeline entries for WIP prefix changes in pull requests (go-gitea#36518)
silverwind added a commit to silverwind/gitea that referenced this pull request Feb 12, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into dropdowncss
a4d46ca 
* origin/main: (34 commits)
  Fine tune diff highlighting (go-gitea#36592)
  Add code editor setting dropdowns (go-gitea#36534)
  Update to go 1.26.0 and golangci-lint 2.9.0 (go-gitea#36588)
  Improve diff highlighting (go-gitea#36583)
  Fix markup code block layout (go-gitea#36578)
  Remove striped tables in UI (go-gitea#36509)
  Fix vertical alignment of `.commit-sign-badge` children (go-gitea#36570)
  Fix mirror sync parser and fix mirror messages (go-gitea#36504)
  Update JS and PY deps (go-gitea#36576)
  Add viewer controller for mermaid (zoom, drag) (go-gitea#36557)
  Misc typescript tweaks (go-gitea#36523)
  Use full-file highlighting for diff sections (go-gitea#36561)
  fix(diff): reprocess htmx content after loading more files (go-gitea#36568)
  [skip ci] Updated translations via Crowdin
  Add wrap to runner label list (go-gitea#36565)
  fix: add dnf5 command for Fedora in RPM package instructions (go-gitea#36527)
  Enable pagination on GiteaDownloader.getIssueReactions() (go-gitea#36549)
  Refactor merge conan and container auth preserve actions taskID (go-gitea#36560)
  Fix assignee sidebar links and empty placeholder after go-gitea#32465 refactor (go-gitea#36559)
  Fix various version parsing problems (go-gitea#36553)
  ...
silverwind added a commit to silverwind/gitea that referenced this pull request Feb 12, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into reltime
9108450 
* origin/main: (152 commits)
  Fine tune diff highlighting (go-gitea#36592)
  Add code editor setting dropdowns (go-gitea#36534)
  Update to go 1.26.0 and golangci-lint 2.9.0 (go-gitea#36588)
  Improve diff highlighting (go-gitea#36583)
  Fix markup code block layout (go-gitea#36578)
  Remove striped tables in UI (go-gitea#36509)
  Fix vertical alignment of `.commit-sign-badge` children (go-gitea#36570)
  Fix mirror sync parser and fix mirror messages (go-gitea#36504)
  Update JS and PY deps (go-gitea#36576)
  Add viewer controller for mermaid (zoom, drag) (go-gitea#36557)
  Misc typescript tweaks (go-gitea#36523)
  Use full-file highlighting for diff sections (go-gitea#36561)
  fix(diff): reprocess htmx content after loading more files (go-gitea#36568)
  [skip ci] Updated translations via Crowdin
  Add wrap to runner label list (go-gitea#36565)
  fix: add dnf5 command for Fedora in RPM package instructions (go-gitea#36527)
  Enable pagination on GiteaDownloader.getIssueReactions() (go-gitea#36549)
  Refactor merge conan and container auth preserve actions taskID (go-gitea#36560)
  Fix assignee sidebar links and empty placeholder after go-gitea#32465 refactor (go-gitea#36559)
  Fix various version parsing problems (go-gitea#36553)
  ...
Sirherobrine23 pushed a commit to Sirherobrine23/gitea that referenced this pull request Mar 4, 2026
@tyroneyeh @wxiaoguang @Sirherobrine23
Fix assignee sidebar links and empty placeholder after go-gitea#32465 …
32a03b7 
…refactor (go-gitea#36559)

Follow-up to go-gitea#32465: Fix the assignee sidebar after the selector
refactor.


Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.25 This PR should be backported to Gitea 1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs modifies/frontend modifies/templates This PR modifies the template files type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tyroneyeh @wxiaoguang @lunny @GiteaBot