Skip to content

Prevent navigation keys from triggering actions during IME composition#36540

Merged
wxiaoguang merged 5 commits intogo-gitea:mainfrom
Theproudcold:main
Feb 8, 2026
Merged

Prevent navigation keys from triggering actions during IME composition#36540
wxiaoguang merged 5 commits intogo-gitea:mainfrom
Theproudcold:main

Conversation

@Theproudcold
Copy link
Copy Markdown
Contributor

Fixes #36532

Refined the Enter key trigger logic in the repository filter to prevent actions during IME composition.

By checking the e.isComposing property, the filter now correctly distinguishes between "confirming an IME candidate" and "submitting the search." This prevents premature search triggers when users press Enter to select Chinese/Japanese characters.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 6, 2026
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Feb 6, 2026

Looks ok, thanks.

Not required but would be nice maybe to fix it for all places where we bind the Enter key. A quick search reveals:

web_src/js/components/DashboardRepoList.vue-        case 'Enter':
web_src/js/components/RepoBranchTagSelector.vue:      } else if (e.key === 'Enter') {
web_src/js/components/RepoFileSearch.vue:  } else if (e.key === 'Enter') {
web_src/js/features/common-form.ts:    if (e.key !== 'Enter') return;
web_src/js/features/comp/EditorMarkdown.ts:    } else if (e.key === 'Enter' && !e.shiftKey && !e.ctrlKey && !e.metaKey && !e.altKey) {
web_src/js/features/repo-issue.ts:    if (e.altKey && e.key === 'Enter') {
web_src/js/modules/fomantic/dropdown.ts:    if (e.key === 'Enter') {
web_src/js/webcomponents/overflow-menu.ts:        } else if (e.key === ' ' || e.code === 'Enter') {

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 6, 2026
@wxiaoguang
Copy link
Copy Markdown
Contributor

Still need more improvements, I made some changes in 81b74c1

@wxiaoguang wxiaoguang changed the title fix(dashboard): Prevent Enter key from triggering actions during IM… Prevent navigation keys from triggering actions during IME composition Feb 8, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2026
@wxiaoguang wxiaoguang merged commit ef529de into go-gitea:main Feb 8, 2026
24 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Feb 8, 2026
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 9, 2026
* giteaofficial/main:
  Refactor merge conan and container auth preserve actions taskID (go-gitea#36560)
  Fix assignee sidebar links and empty placeholder after go-gitea#32465 refactor (go-gitea#36559)
  Fix various version parsing problems (go-gitea#36553)
  Fix highlight diff result (go-gitea#36539)
  Refactor Nuget Auth to reuse Basic Auth Token Validation (go-gitea#36558)
  Update go dependencies (go-gitea#36548)
  Prevent navigation keys from triggering actions during IME composition (go-gitea#36540)
  Fix various mermaid bugs (go-gitea#36547)
  Add `elk` layout support to mermaid (go-gitea#36486)
  Allow configuring default PR base branch (fixes go-gitea#36412) (go-gitea#36425)
  [skip ci] Updated translations via Crowdin
  Color command/error logs in Actions log (go-gitea#36538)
  Add paging headers (go-gitea#36521)
  Fix issues filter dropdown showing empty label scope section (go-gitea#36535)
  [SECURITY] fix: Adjust the toolchain version (go-gitea#36537)
  Hide `add-matcher` and `remove-matcher` from actions job logs (go-gitea#36520)
  Improve timeline entries for WIP prefix changes in pull requests (go-gitea#36518)
Sirherobrine23 pushed a commit to Sirherobrine23/gitea that referenced this pull request Mar 4, 2026
go-gitea#36540)

Fixes  go-gitea#36532 

Refined the Enter key trigger logic in the repository filter to prevent
actions during IME composition.

By checking the e.isComposing property, the filter now correctly
distinguishes between "confirming an IME candidate" and "submitting the
search." This prevents premature search triggers when users press Enter
to select Chinese/Japanese characters.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search bar triggers "Enter" event during IME composition (Chinese input)

4 participants