Skip to content

Fix assignee sidebar links and empty placeholder after #32465 refactor (#36559)#36563

Merged
wxiaoguang merged 1 commit intogo-gitea:release/v1.25from
GiteaBot:backport-36559-v1.25
Feb 9, 2026
Merged

Fix assignee sidebar links and empty placeholder after #32465 refactor (#36559)#36563
wxiaoguang merged 1 commit intogo-gitea:release/v1.25from
GiteaBot:backport-36559-v1.25

Conversation

@GiteaBot
Copy link
Copy Markdown
Collaborator

@GiteaBot GiteaBot commented Feb 9, 2026

Backport #36559 by @tyroneyeh

Follow-up to #32465: Fix the assignee sidebar after the selector refactor.

Changes:

  1. Candidate assignee links now use QueryBuild to point to the correct issues/pulls list, fixing cloned dropdown items' href.
  2. Removed redundant rendering of existing assignees; $hasAssignees now controls the "no assignees" placeholder safely.

This ensures the sidebar works correctly and the empty-list placeholder is shown/hidden as expected.

Before:
image

After:
20260208_222444

…refactor (go-gitea#36559)

Follow-up to go-gitea#32465: Fix the assignee sidebar after the selector
refactor.


Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBot GiteaBot added modifies/docs modifies/frontend modifies/templates This PR modifies the template files type/bug lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 9, 2026
@GiteaBot GiteaBot added this to the 1.25.5 milestone Feb 9, 2026
@GiteaBot GiteaBot requested review from lunny and wxiaoguang February 9, 2026 03:05
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 9, 2026 03:15
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 9, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 9, 2026
@wxiaoguang wxiaoguang merged commit 9b3a952 into go-gitea:release/v1.25 Feb 9, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs modifies/frontend modifies/templates This PR modifies the template files type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants