Refactor git command context & pipeline

[wxiaoguang]

Less and simpler code, fewer bugs

[Copilot]

Pull request overview

This PR refactors the git command execution pipeline to simplify code and improve maintainability. The core changes replace manual os.Pipe() management with a cleaner WithStdoutReader approach, and introduce a new gitcmd.Context interface that provides CancelWithCause for better error propagation.

Changes:

• Introduced new gitcmd.Context interface with CancelWithCause method for cleaner error handling in pipeline functions
• Replaced manual os.Pipe() creation and cleanup with WithStdoutReader pattern across all git command usages
• Removed unused git timeout configurations (Default, Clone, Pull) and simplified timeout handling logic
• Updated process.Manager to use CancelCauseFunc instead of context.CancelFunc for better cause tracking

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
modules/git/gitcmd/context.go	New file introducing the Context interface with CancelWithCause method
modules/git/gitcmd/command.go	Removed default timeout logic, updated pipeline function signature to use new Context interface
modules/process/process.go	Changed Cancel field type from context.CancelFunc to CancelCauseFunc
modules/process/manager.go	Updated context creation to use WithCancelCause, introduced CancelCauseFunc type
modules/queue/workerqueue.go	Updated ctxRunCancel type to process.FinishedFunc
modules/nosql/manager.go	Updated finished field type to process.FinishedFunc
modules/log/init.go	Updated to convert FinishedFunc to context.CancelFunc
modules/setting/git.go	Removed Default, Clone, and Pull timeout configuration fields
custom/conf/app.example.ini	Removed unused timeout configuration examples
modules/git/git.go	Removed SetDefaultCommandExecutionTimeout call
services/cron/tasks_basic.go	Changed to use Git.Timeout.GC instead of Default
services/repository/gitgraph/graph.go	Replaced os.Pipe with WithStdoutReader, updated pipeline function signature
services/repository/files/temp_repo.go	Replaced os.Pipe with WithStdoutReader, updated pipeline function signature
services/repository/contributors_graph.go	Replaced os.Pipe with WithStdoutReader, removed manual close
services/pull/pull.go	Replaced os.Pipe with WithStdoutReader, updated pipeline function signature
services/pull/patch_unmerged.go	Replaced os.Pipe with WithStdoutReader, updated pipeline function signature
services/pull/patch.go	Updated pipeline function signature, removed manual stderr close
services/pull/merge_prepare.go	Replaced os.Pipe with WithStdoutReader, renamed filepath to treePath for clarity
services/gitdiff/gitdiff.go	Removed explicit timeout setting
routers/private/hook_verification.go	Replaced os.Pipe with WithStdoutReader for both verifyCommits and readAndVerifyCommit
modules/git/submodule.go	Replaced os.Pipe with WithStdoutReader, removed manual close
modules/git/repo_stats.go	Replaced os.Pipe with WithStdoutReader, removed manual close
modules/git/grep.go	Updated pipeline function to use new Context interface with CancelWithCause
modules/git/diff.go	Replaced os.Pipe with WithStdoutReader, updated pipeline function signature
modules/git/catfile_batch_reader.go	Removed WithUseContextTimeout call
modules/gitrepo/blame.go	Removed WithUseContextTimeout call
routers/web/repo/githttp.go	Minor formatting improvement for multi-line function call

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[wxiaoguang]

Found an incorrect test, also fixed in Refactor git command stdio pipe #36422 together

--- FAIL: TestRunWithContextTimeout (0.00s)
    --- FAIL: TestRunWithContextTimeout/WithTimeout (0.00s)
        command_test.go:125: 
            	Error Trace:	/home/runner/work/gitea/gitea/modules/git/gitcmd/command_test.go:125
            	Error:      	Expected error with "context deadline exceeded" in chain but got nil.
            	Test:       	TestRunWithContextTimeout/WithTimeout
FAIL