Fix 500 error caused by deleted users on issues (#3675)

[ghost]

This PR will resolve 500s caused by deleted users.

[lunny]

hihi, I think one should not LGTM himself's PR.

[tboerger]

Needs to be rebased, otherwise LGTM

[tboerger]

Please reopen against master.

[bkcsoft]

@tboerger you can do that by editing the PR 😉 (found that out today actually 😆 https://github.com/blog/2224-change-the-base-branch-of-a-pull-request )

[codecov-io]

Current coverage is 2.18% (diff: 0.00%)

No coverage report found for master at 5c54243.

Powered by Codecov. Last update 5c54243...fd6be0d

[bkcsoft]

Please still print this error if the User infact doesn't exist 🙂

[strk]

An automated test would be great here

[strk]

@lunny can't lgtm check for self-lgtm ? (and I think your comment also counted)

[lunny]

lgtm can check but not the default. I have configed it correctly but the problem is lgtm don't know not LGTM.

Fixed

[ghost]

@bkcsoft Would this work?

[lunny]

It seems it's no need this PR via Files changed.

[strk]

Having an automated test and instructions on how to reproduce the bug would help evaluating the need for change.

[lunny]

Yes

[ghost]

This is in reference to gogs/gogs#3675

[strk]

I've just tried reproducing with these steps:

• Create a user X
• Have user X file issue on project Y
• Delete user X
• Visit issues of project Y
  Got the 505 internal error, before and after applying this patch.

Logs say:

2016/11/06 19:53:59 [...outers/repo/issue.go:188 Issues()] [E] Issues: LoadAttributes [42705]: user does not exist [uid: 3, name: ]
2016/11/06 19:53:59 [D] Template: status/500

[andreynering]

I tried this but it doesn't fix the error.

[codecov-io]

Current coverage is 3.14% (diff: 0.00%)

No coverage report found for master at 5c54243.

Powered by Codecov. Last update 5c54243...a6c487f

[ghost]

@andreynering @strk

Sorry, took me awhile but this should fix the error completely, as I forgot to reset the err variable.

[strk]

The lgtm service is somewhat lame in that it doesn't reset upon pushing new commits.
@LefsFlarey: an automated test would still be great here, would you consider giving it a try ?

[strk]

Tested, now works, but the link to the ghost author is a 404 (maybe should be a page explaining what "Gost" is ? Or not be a link at all ?)

[strk]

Also, the "Ghost" user avatar seems to be the default avatar, maybe we want a Ghost-ed gopher ? :)

[strk]

btw, I noticed the user does not turn into a link while in the Issue page, so it's only in the "Issues List" page that it needs be fixed.

(OT: the urls to user profile should really be changed IMHO - but it's for another discussion)

[lunny]

LGTM