Remove `node-check` and `go-check`, support node prerelease versions by silverwind · Pull Request #36382 · go-gitea/gitea

silverwind · 2026-01-15T17:31:29Z

Remove those checks for the sake of build performance and because go and node will fail anyways if their versions are incorrect.
Support pre-release Node version for determining NODE_VARS.
Update to the chinese READMEs to mention pnpm which is already present in english README.

wxiaoguang · 2026-01-22T02:56:22Z

I am just curious, why should we manually keep checking the toolchain versions?

I think node, pnmp, golang should be able to tell developers if their versions don't match? They all have their versions declared in their package files.

So, ideally, all these checks should be removed?

silverwind · 2026-01-22T03:10:22Z

Yes, those tools should fail with somewhat readable errors if their version does not match the specified range. For the sake of build performance, we could remove all these checks.

silverwind · 2026-01-22T03:14:22Z

It's strict for node with pnpm: https://pnpm.io/settings#enginestrict

Regardless of this configuration, installation will always fail if a project (not a dependency) specifies an incompatible version in its engines field.

pnpm version is lax by default: https://pnpm.io/settings#packagemanagerstrictversion

silverwind · 2026-01-22T03:41:01Z

@wxiaoguang I removed those checks now.

Makefile

wxiaoguang · 2026-01-22T03:51:14Z

Makefile

-NODE_VERSION := $(shell printf "%03d%03d%03d" $(shell node -v 2>/dev/null | cut -c2- | tr '.' ' '))
+NODE_VERSION := $(shell printf "%03d%03d%03d" $(shell node -v 2>/dev/null | cut -c2- | sed 's/-.*//' | tr '.' ' '))
 ifeq ($(shell test "$(NODE_VERSION)" -lt "022018000"; echo $$?),0)
 	NODE_VARS := NODE_OPTIONS="--experimental-strip-types"


https://nodejs.org/docs/latest-v22.x/api/cli.html

Don't see an option named "experimental-strip-types"

The option was removed with 22.18.0 where it became the default.

OK, found it here: https://nodejs.org/docs/v22.6.0/api/cli.html#--experimental-strip-types

Ref: nodejs/node@8d1f5df313

Wouldn't it be easier to do so? Totally remove the version check.

"experimental-strip-types" is a hidden flag in new releases

# Enable typescript support in Node.js before 22.18, this option is also compatible with new Node.js 24 # TODO: Remove this once we can raise the minimum Node.js version to 22.18 (alpine >= 3.23) NODE_VARS := NODE_OPTIONS="--experimental-strip-types"

Either is fine to me

We could always set it too because node ignores unknown NODE_OPTIONS luckily.

~~It only ignores the hidden flag it knows. That's a pretty good design, for compatibility~~

Details

It probably works because of this: https://github.com/nodejs/node/blob/9e201e61fd8e4b8bfb74409151cbcbbc7377ca67/src/node_options.cc#L1102

I'm not comfortable relying on undocumented options so I will revert a401556. In a few months we can remove it anyways.

This reverts commit a401556.

wxiaoguang · 2026-01-22T05:18:52Z

Random CI failure is fixed in Refactor git command stdio pipe #36422

# This is the 1st commit message: feat: Add max-parallel implementation inside the Gitea server # This is the commit message go-gitea#2: fix: Remove MatrixID and Capacity functionality # This is the commit message go-gitea#3: Fix incorrect text content detection (go-gitea#36364) Fix go-gitea#36325 # This is the commit message go-gitea#4: clean watches when make a repository private and check permission when send release emails (go-gitea#36319) # This is the commit message go-gitea#5: Fix bug when compare in the pull request (go-gitea#36363) The pull request comparison should not use `direct compare`. # This is the commit message go-gitea#6: Fix permission check on org project operations (go-gitea#36318) # This is the commit message go-gitea#7: Release attachments must belong to the intended repo (go-gitea#36347) # This is the commit message go-gitea#8: Indicate when only optional checks failed (go-gitea#36367) Currently it's not clear that you can merge a PR when only optional checks failed: <img width="922" height="447" alt="Screenshot 2026-01-14 at 4 08 17 pm" src="https://github.com/user-attachments/assets/e11670c7-5ab9-42d7-af09-2d8a8fd532d3" /> This PR changes the text to say "Some optional checks failed" when only optional checks failed: <img width="922" height="443" alt="Screenshot 2026-01-14 at 3 59 08 pm" src="https://github.com/user-attachments/assets/9ea69b13-38d6-4cfc-b4f7-952eff58e546" /> When a required check fails it'll still say "Some checks failed": <img width="928" height="343" alt="Screenshot 2026-01-14 at 3 59 20 pm" src="https://github.com/user-attachments/assets/d3764a95-9737-4482-851e-d3406b1e4d76" /> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> # This is the commit message go-gitea#9: Rename CSS variables and improve colorblind themes (go-gitea#36353) Followup go-gitea#36215, rename the variables for consistency with existing vars and change green to value of `--color-blue` in the relevant color blind themes: <img width="1305" height="303" alt="image" src="https://github.com/user-attachments/assets/3d131ab7-99ab-4b03-93ab-715ce0030b08" /> The blue coloring also matched GitHub: <img width="1313" height="393" alt="image" src="https://github.com/user-attachments/assets/f97e35b2-4ff4-49b0-841f-ffd49a02e03d" /> --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> # This is the commit message go-gitea#10: Migrate to `import.meta.env` and clean up types and eslint (go-gitea#36362) `import.meta.env` is supported in both vitest and webpack [as of recent](webpack/webpack#19996), so replace all previous use of `process.env` with it. Current usage is limited to test files, I've also verified it works in actual frontend code. `webpack/module` is added to typescript types which includes the definition for `import.meta.env`. I've also made the eslint globals more precise. Finally, `__webpack_public_path__` is removed from our type definitions because `webpack/module` also provides it. # This is the commit message go-gitea#11: Add chunked transfer encoding support for LFS uploads (go-gitea#36380) Enable chunked transfer encoding for Git LFS uploads by adding Transfer-Encoding: chunked header to upload action responses. This prevents large file uploads (100+ MB) from being blocked by reverse proxies like Cloudflare that buffer non-chunked requests. Fix go-gitea#22233 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> # This is the commit message go-gitea#12: Fix bug on notification read (go-gitea#36339) When a user has been revoked permission to access a repository, the related notification could still be visited. But the repository's information should not be leaked any more. # This is the commit message go-gitea#13: Add ability to download subpath archive (go-gitea#36371) closes: go-gitea#4478 --------- Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> # This is the commit message go-gitea#14: Update JS and PY deps (go-gitea#36383) - Update JS and PY dependencies - Workaround stylelint/stylelint#8893 by moving the stylint config file to JS - Regenerate SVGs - Bump to python 3.14 in devcontainer and actions - Verified `@github/text-expander-element` - Removed obsolete type stub # This is the commit message go-gitea#15: Fix CODEOWNERS review request attribution using comment metadata (go-gitea#36348) Fixes go-gitea#36333 ## Problem When CODEOWNERS automatically assigns reviewers to a pull request, the timeline incorrectly shows the PR author as the one who requested the review (e.g., "PR_AUTHOR requested review from CODE_OWNER"). This is misleading since the action was triggered automatically by CODEOWNERS rules, not by the PR author. ## Solution Store CODEOWNERS attribution in comment metadata instead of changing the doer user: - Add `SpecialDoerName` field to `CommentMetaData` struct (value: `"CODEOWNERS"` for CODEOWNERS-triggered requests) - Pass `isCodeOwners=true` to `AddReviewRequest` and `AddTeamReviewRequest` functions - Template can check this metadata to show appropriate attribution message --------- Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> # This is the commit message go-gitea#16: Hide delete directory button for mirror or archive repository and disable the menu item if user have no permission (go-gitea#36384) # This is the commit message go-gitea#17: add support for archive-upload rpc (go-gitea#36391) Add support for fetching archives with `git archive --remote <repo-url>` closes: go-gitea#23425 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> # This is the commit message go-gitea#18: fix: typos in comments (go-gitea#36394) # This is the commit message go-gitea#19: Refactor git command stdio pipe (go-gitea#36393) And remove the incorrect `ensureValidGitRepository` # This is the commit message go-gitea#20: Some refactors about GetMergeBase (go-gitea#36186) Maybe fix go-gitea#32018 - Use `gitrepo.GetMergeBase` method instead of other two implementations. - Add `FetchRemoteCommit` so that we don't need to add many `remote` to the git repository to avoid possible git lock conflicts. A lock will start when invoke the function, it will be invoked when cross-repository comparing. The head repository will fetch the base repository's base commit id. In most situations, it should lock the fork repositories so that it should not become a bottleneck. - Improve `GetCompareInfo` to remove unnecessarily adding remote. - Remove unnecessary parameters of `SignMerge`. # This is the commit message go-gitea#21: Refactor git command stderr handling (go-gitea#36402) And clean up legacy fragile & incorrect logic # This is the commit message go-gitea#22: [skip ci] Updated translations via Crowdin # This is the commit message go-gitea#23: Fix missing repository id when migrating release attachments (go-gitea#36389) This PR fixes missed repo_id on the migration of attachments to Gitea. It also provides a doctor check to fix the dirty data on the database. Refactor git command context & pipeline (go-gitea#36406) Less and simpler code, fewer bugs Allow foreachref parse max tokens from 4*64KB to 4MB (go-gitea#36414) Fix go-gitea#36408 --------- Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Update material-icon-theme to v5.31.0 (go-gitea#36427) Update chroma to v2.23.0 (go-gitea#36423) Fix markdown newline handling during IME composition (go-gitea#36421) ### Summary Fix incorrect newline handling in markdown editor when using IME input. ### Details While composing text with an IME, pressing Enter should not trigger markdown indentation logic. This change skips indentation handling during composition by checking `e.isComposing`. This prevents unexpected line breaks and formatting issues for CJK users. [skip ci] Updated translations via Crowdin Fix typos: unknow -> unknown, pktLineTypeUnknow -> pktLineTypeUnknown (go-gitea#36419) Fix issue filter menu layout (go-gitea#36426) Fix go-gitea#36420 Fix spelling (go-gitea#36399) Signed-off-by: Thomas Beutlich <115483027+thbeu@users.noreply.github.com> Refactor git command stdio pipe (go-gitea#36422) Most potential deadlock problems should have been fixed, and new code is unlikely to cause new problems with the new design. Also raise the minimum Git version required to 2.6.0 (released in 2015) Remove `node-check` and `go-check`, support node prerelease versions (go-gitea#36382) 1. Remove those checks for the sake of build performance and because go and node will fail anyways if their versions are incorrect. 3. Support pre-release Node version for determining NODE_VARS. 2. Update to the chinese READMEs to mention `pnpm` which is already present in english README. --------- Co-authored-by: techknowlogick <techknowlogick@gitea.com> Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> fix: Adjust the unittests fix: Lint issues fix: Adjust the swagger config

* giteaofficial/main: Remove `node-check` and `go-check`, support node prerelease versions (go-gitea#36382) Refactor git command stdio pipe (go-gitea#36422) Fix spelling (go-gitea#36399) Fix issue filter menu layout (go-gitea#36426) Fix typos: unknow -> unknown, pktLineTypeUnknow -> pktLineTypeUnknown (go-gitea#36419) [skip ci] Updated translations via Crowdin Fix markdown newline handling during IME composition (go-gitea#36421) Update chroma to v2.23.0 (go-gitea#36423) Update material-icon-theme to v5.31.0 (go-gitea#36427)

Strip prerelease tag from NODE_VERSION

021297d

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2026

github-actions bot added the modifies/internal label Jan 15, 2026

silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 15, 2026

lunny approved these changes Jan 15, 2026

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2026

techknowlogick approved these changes Jan 22, 2026

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 22, 2026

techknowlogick enabled auto-merge (squash) January 22, 2026 02:40

Merge branch 'main' into nodepre

285e647

techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 22, 2026

Merge branch 'main' into nodepre

d38e439

wxiaoguang disabled auto-merge January 22, 2026 02:54

wxiaoguang removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 22, 2026

wxiaoguang marked this pull request as draft January 22, 2026 02:56

wxiaoguang marked this pull request as ready for review January 22, 2026 03:36

remove node-check and go-check

1d39c3f

github-actions bot added the modifies/docs label Jan 22, 2026

silverwind changed the title ~~Strip prerelease tag from NODE_VERSION~~ Remove node-check and go-check Jan 22, 2026

silverwind requested a review from wxiaoguang January 22, 2026 03:42

wxiaoguang reviewed Jan 22, 2026

View reviewed changes

Makefile Show resolved Hide resolved

wxiaoguang approved these changes Jan 22, 2026

View reviewed changes

wxiaoguang reviewed Jan 22, 2026

View reviewed changes

wxiaoguang marked this pull request as draft January 22, 2026 03:52

wxiaoguang marked this pull request as ready for review January 22, 2026 03:55

silverwind changed the title ~~Remove node-check and go-check~~ Remove node-check and go-check, support node prerelease versions Jan 22, 2026

silverwind added 2 commits January 22, 2026 05:06

statically set NODE_VARS

a401556

Revert "statically set NODE_VARS"

d7de6b8

This reverts commit a401556.

delvh approved these changes Jan 22, 2026

View reviewed changes

Merge branch 'main' into nodepre

03d9155

silverwind merged commit 5f91c51 into go-gitea:main Jan 22, 2026
24 checks passed

GiteaBot added this to the 1.26.0 milestone Jan 22, 2026

silverwind deleted the nodepre branch January 22, 2026 08:30

Uh oh!

Conversation

silverwind commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Jan 22, 2026

Uh oh!

silverwind commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverwind commented Jan 22, 2026

Uh oh!

Uh oh!

wxiaoguang Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

silverwind Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

silverwind Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

silverwind Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

silverwind Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

wxiaoguang commented Jan 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

silverwind commented Jan 15, 2026 •

edited

Loading

silverwind commented Jan 22, 2026 •

edited

Loading

silverwind commented Jan 22, 2026 •

edited

Loading

wxiaoguang Jan 22, 2026 •

edited

Loading

wxiaoguang Jan 22, 2026 •

edited

Loading