render plain text file if the LFS object doesn't exist #31812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lafriks
approved these changes
Aug 9, 2024
GiteaBot
added
lgtm/need 1
lunny
reviewed
Aug 9, 2024
bohde
force-pushed
the
rb/fallback-to-plaintext-lfs-if-pointer-is-missing
branch
from
d3970dd
to
3ac3418
Compare
lunny
reviewed
Aug 12, 2024
bohde
force-pushed
the
rb/fallback-to-plaintext-lfs-if-pointer-is-missing
branch
from
3ac3418
to
b2543a6
Compare
lunny
approved these changes
Aug 13, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
auto-merge was automatically disabled
August 14, 2024 17:10
Head branch was pushed to by a user without write access
bohde
force-pushed
the
rb/fallback-to-plaintext-lfs-if-pointer-is-missing
branch
from
b2543a6
to
619397d
Compare
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 16, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Add missing repository type filter parameters to pager (go-gitea#31832) Fix panic of ssh public key page after deletion of auth source (go-gitea#31829) [skip ci] Updated translations via Crowdin render plain text file if the LFS object doesn't exist (go-gitea#31812)
4kProgrammer
pushed a commit
to 4kProgrammer/gitea
that referenced
this pull request
Aug 20, 2024
…gfgdfg We had an issue where a repo was using LFS to store a file, but the user did not push the file. When trying to view the file, Gitea returned a 500 HTTP status code referencing `ErrLFSObjectNotExist`. It appears the intent was the render this file as plain text, but the conditional was flipped. I've also added a test to verify that the file is rendered as plain text.
4kProgrammer
pushed a commit
to 4kProgrammer/gitea
that referenced
this pull request
Aug 20, 2024
…gfgdfg We had an issue where a repo was using LFS to store a file, but the user did not push the file. When trying to view the file, Gitea returned a 500 HTTP status code referencing `ErrLFSObjectNotExist`. It appears the intent was the render this file as plain text, but the conditional was flipped. I've also added a test to verify that the file is rendered as plain text.
4kProgrammer
pushed a commit
to 4kProgrammer/gitea
that referenced
this pull request
Aug 20, 2024
Squashed commit: [e1468e2] Fixes for unreachable project issues when transfer repository from organization (go-gitea#31770) dfhgfdhfghfg When transferring repositories that have issues linked to a project board to another organization, the issues remain associated with the original project board. This causes the columns in the project board to become bugged, making it difficult to move other issues in or out of the affected columns. As a solution, I removed the issue relations since the other organization does not have this project table. Fix for go-gitea#31538 Co-authored-by: Jason Song <[email protected]> [c39643f] fghfghf [38a09ea] render plain text file if the LFS object doesn't exist (go-gitea#31812)gfgdfg We had an issue where a repo was using LFS to store a file, but the user did not push the file. When trying to view the file, Gitea returned a 500 HTTP status code referencing `ErrLFSObjectNotExist`. It appears the intent was the render this file as plain text, but the conditional was flipped. I've also added a test to verify that the file is rendered as plain text. [2477511] Add spacing to global error message (go-gitea#31826) Fixes go-gitea#31717. Include Typescript files in Tailwind config so they can be pre-processed.  [5bcab0b] [skip ci] Updated translations via Crowdin [fe7c941] Scroll images in project issues separately from the remaining issue (go-gitea#31683) As discussed in go-gitea#31667 & go-gitea#26561, when a card on a Project contains images, they can overflow the card on its containing column. This aims to fix this issue via snapping scrollbars. --- Issue go-gitea#31667 is open to discussion as there should be room for improvement. [8883d99] Support issue template assignees (go-gitea#31083) Resolve go-gitea#13955
4kProgrammer
pushed a commit
to 4kProgrammer/gitea
that referenced
this pull request
Aug 20, 2024
Squashed commit: [e1468e2] Fixes for unreachable project issues when transfer repository from organization (go-gitea#31770) dfhgfdhfghfg When transferring repositories that have issues linked to a project board to another organization, the issues remain associated with the original project board. This causes the columns in the project board to become bugged, making it difficult to move other issues in or out of the affected columns. As a solution, I removed the issue relations since the other organization does not have this project table. Fix for go-gitea#31538 Co-authored-by: Jason Song <[email protected]> [c39643f] fghfghf [38a09ea] render plain text file if the LFS object doesn't exist (go-gitea#31812)gfgdfg We had an issue where a repo was using LFS to store a file, but the user did not push the file. When trying to view the file, Gitea returned a 500 HTTP status code referencing `ErrLFSObjectNotExist`. It appears the intent was the render this file as plain text, but the conditional was flipped. I've also added a test to verify that the file is rendered as plain text. [2477511] Add spacing to global error message (go-gitea#31826) Fixes go-gitea#31717. Include Typescript files in Tailwind config so they can be pre-processed.  [5bcab0b] [skip ci] Updated translations via Crowdin [fe7c941] Scroll images in project issues separately from the remaining issue (go-gitea#31683) As discussed in go-gitea#31667 & go-gitea#26561, when a card on a Project contains images, they can overflow the card on its containing column. This aims to fix this issue via snapping scrollbars. --- Issue go-gitea#31667 is open to discussion as there should be room for improvement. [8883d99] Support issue template assignees (go-gitea#31083) Resolve go-gitea#13955
4kProgrammer
pushed a commit
to 4kProgrammer/gitea
that referenced
this pull request
Aug 20, 2024
Squashed commit: [e1468e2] Fixes for unreachable project issues when transfer repository from organization (go-gitea#31770) dfhgfdhfghfg When transferring repositories that have issues linked to a project board to another organization, the issues remain associated with the original project board. This causes the columns in the project board to become bugged, making it difficult to move other issues in or out of the affected columns. As a solution, I removed the issue relations since the other organization does not have this project table. Fix for go-gitea#31538 Co-authored-by: Jason Song <[email protected]> [c39643f] fghfghf [38a09ea] render plain text file if the LFS object doesn't exist (go-gitea#31812)gfgdfg We had an issue where a repo was using LFS to store a file, but the user did not push the file. When trying to view the file, Gitea returned a 500 HTTP status code referencing `ErrLFSObjectNotExist`. It appears the intent was the render this file as plain text, but the conditional was flipped. I've also added a test to verify that the file is rendered as plain text. [2477511] Add spacing to global error message (go-gitea#31826) Fixes go-gitea#31717. Include Typescript files in Tailwind config so they can be pre-processed.  [5bcab0b] [skip ci] Updated translations via Crowdin [fe7c941] Scroll images in project issues separately from the remaining issue (go-gitea#31683) As discussed in go-gitea#31667 & go-gitea#26561, when a card on a Project contains images, they can overflow the card on its containing column. This aims to fix this issue via snapping scrollbars. --- Issue go-gitea#31667 is open to discussion as there should be room for improvement. [8883d99] Support issue template assignees (go-gitea#31083) Resolve go-gitea#13955
4kProgrammer
pushed a commit
to 4kProgrammer/gitea
that referenced
this pull request
Aug 20, 2024
Squashed commit: [e1468e2] Fixes for unreachable project issues when transfer repository from organization (go-gitea#31770) dfhgfdhfghfg When transferring repositories that have issues linked to a project board to another organization, the issues remain associated with the original project board. This causes the columns in the project board to become bugged, making it difficult to move other issues in or out of the affected columns. As a solution, I removed the issue relations since the other organization does not have this project table. Fix for go-gitea#31538 Co-authored-by: Jason Song <[email protected]> [c39643f] fghfghf [38a09ea] render plain text file if the LFS object doesn't exist (go-gitea#31812)gfgdfg We had an issue where a repo was using LFS to store a file, but the user did not push the file. When trying to view the file, Gitea returned a 500 HTTP status code referencing `ErrLFSObjectNotExist`. It appears the intent was the render this file as plain text, but the conditional was flipped. I've also added a test to verify that the file is rendered as plain text. [2477511] Add spacing to global error message (go-gitea#31826) Fixes go-gitea#31717. Include Typescript files in Tailwind config so they can be pre-processed.  [5bcab0b] [skip ci] Updated translations via Crowdin [fe7c941] Scroll images in project issues separately from the remaining issue (go-gitea#31683) As discussed in go-gitea#31667 & go-gitea#26561, when a card on a Project contains images, they can overflow the card on its containing column. This aims to fix this issue via snapping scrollbars. --- Issue go-gitea#31667 is open to discussion as there should be room for improvement. [8883d99] Support issue template assignees (go-gitea#31083) Resolve go-gitea#13955
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue where a repo was using LFS to store a file, but the user did not push the file. When trying to view the file, Gitea returned a 500 HTTP status code referencing
ErrLFSObjectNotExist. It appears the intent was the render this file as plain text, but the conditional was flipped. I've also added a test to verify that the file is rendered as plain text.