Improve issue card #26561

yp05327 · 2023-08-17T04:53:32Z

Before:

After:

ps:

I think we don't need attachment images in issue cards, as if there are too many images in this issue, it will take too many spaces.
maybe we don't need target="_blank" here.

templates/repo/issue/card.tmpl

silverwind · 2023-08-17T12:31:58Z

Wonder whether we should show assignees, milestones and labels at all. I think I prefer a lightweight display like GitHub.

delvh · 2023-08-17T14:40:05Z

Depends.
I can see arguments for both sides, so I'll stay neutral to that.
Perhaps leaning a bit more towards keeping it.

silverwind · 2023-08-17T14:59:48Z

Those things are mostly only relevant to project members, but I think the primary purpose of pinned issues is to guide users to known issues and users usually wouldn't care about these things.

silverwind · 2023-08-17T22:31:47Z

I guess we should have a option in the issue card template to render full (projects) or reduced (pins). But that is material for another PR.

Co-authored-by: delvh <[email protected]>

silverwind · 2023-08-18T19:52:17Z

web_src/css/features/projects.css

@@ -82,12 +83,18 @@
 .card-attachment-images img {
  display: inline-block;
  max-height: 50px;
+  max-width: 100%;
  border-radius: var(--border-radius);
  margin-right: 2px;


Suggested change

margin-right: 2px;

margin-right: 2px;

aspect-ratio: 1;

Better to have this just in case, to ensure the image maintains aspect ratio when scaling width/height.

Would this overlap be a problem?

https://jsfiddle.net/fmapw0ye/

This will fix that overlap, does require max-height on the parent. Better would be direct max-height on the img without any parent.

max-width: 100%; max-height: 100%; aspect-ratio: 1;

puni9869 · 2023-08-23T09:43:28Z

templates/repo/issue/card.tmpl

+			<a {{if $.Page.PageIsProjects}}target="_blank"{{end}} href="{{$.Page.RepoLink}}/issues?labels={{.ID}}">{{RenderLabel ctx .}}</a>
+		{{end}}


{{if $.Page.PageIsProjects}} should it be {{if .PageIsProjects}} 🤔

Not possible in this case.
Go templates are weird when it comes to range:
What is happening here is implicitly a

for _, . := range(Labels) { … }

, with . being the base variable the Go templates can use.
In other words, all previous variables get removed leaving only the properties of a label for a whole iteration.
That's why you need to reference a template global variable by prefixing it with $.

ps: in other places, the "Page" variable is usually called "root" or "ctxData", which means the root context data of this request (aka: ctx.Data in backend code)

silverwind · 2024-05-10T13:08:49Z

I think the image width issue may have been already fixed.

As discussed in go-gitea#31667 & go-gitea#26561, when a card on a Project contains images, they can overflow the card on its containing column. This aims to fix this issue via snapping scrollbars .

yp05327 · 2024-08-12T23:18:07Z

Replaced by #31683

…31683) As discussed in #31667 & #26561, when a card on a Project contains images, they can overflow the card on its containing column. This aims to fix this issue via snapping scrollbars. --- Issue #31667 is open to discussion as there should be room for improvement.

…o-gitea#31683) As discussed in go-gitea#31667 & go-gitea#26561, when a card on a Project contains images, they can overflow the card on its containing column. This aims to fix this issue via snapping scrollbars. --- Issue go-gitea#31667 is open to discussion as there should be room for improvement.

@SimonPistache

…31683) (#31823) Backport #31683 by @SimonPistache As discussed in #31667 & #26561, when a card on a Project contains images, they can overflow the card on its containing column. This aims to fix this issue via snapping scrollbars. --- Issue #31667 is open to discussion as there should be room for improvement. Co-authored-by: Simon Priet <[email protected]>

Squashed commit: [e1468e2] Fixes for unreachable project issues when transfer repository from organization (go-gitea#31770) dfhgfdhfghfg When transferring repositories that have issues linked to a project board to another organization, the issues remain associated with the original project board. This causes the columns in the project board to become bugged, making it difficult to move other issues in or out of the affected columns. As a solution, I removed the issue relations since the other organization does not have this project table. Fix for go-gitea#31538 Co-authored-by: Jason Song <[email protected]> [c39643f] fghfghf [38a09ea] render plain text file if the LFS object doesn't exist (go-gitea#31812)gfgdfg We had an issue where a repo was using LFS to store a file, but the user did not push the file. When trying to view the file, Gitea returned a 500 HTTP status code referencing `ErrLFSObjectNotExist`. It appears the intent was the render this file as plain text, but the conditional was flipped. I've also added a test to verify that the file is rendered as plain text. [2477511] Add spacing to global error message (go-gitea#31826) Fixes go-gitea#31717. Include Typescript files in Tailwind config so they can be pre-processed. ![Screenshot from 2024-08-13 08-44-33](https://github.com/user-attachments/assets/196d7801-e299-4000-8b39-cd9f89917f17) [5bcab0b] [skip ci] Updated translations via Crowdin [fe7c941] Scroll images in project issues separately from the remaining issue (go-gitea#31683) As discussed in go-gitea#31667 & go-gitea#26561, when a card on a Project contains images, they can overflow the card on its containing column. This aims to fix this issue via snapping scrollbars. --- Issue go-gitea#31667 is open to discussion as there should be room for improvement. [8883d99] Support issue template assignees (go-gitea#31083) Resolve go-gitea#13955

…issue (gitea#31683) As discussed in go-gitea/gitea#31667 & go-gitea/gitea#26561, when a card on a Project contains images, they can overflow the card on its containing column. This aims to fix this issue via snapping scrollbars. --- Conflict resolution: none (cherry picked from commit fe7c9416777243264e8482d3af29e30c2b671074) (cherry picked from commit 8e46efe)

…issue (gitea#31683) As discussed in go-gitea/gitea#31667 & go-gitea/gitea#26561, when a card on a Project contains images, they can overflow the card on its containing column. This aims to fix this issue via snapping scrollbars. --- Conflict resolution: none (cherry picked from commit fe7c9416777243264e8482d3af29e30c2b671074)

…issue (gitea#31683) As discussed in go-gitea/gitea#31667 & go-gitea/gitea#26561, when a card on a Project contains images, they can overflow the card on its containing column. This aims to fix this issue via snapping scrollbars. --- Backport: #5029 Conflict resolution: none Modification: Remove the snapping of the images on the projects cards, the images are way too small to notice that when scrolling you're being snapped to these images and when you do notice it, it doesn't make sense as you wouldn't expect it to be snapped. (cherry picked from commit 8e46efe)

improve

3fd3b8f

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 17, 2023

pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 17, 2023

yp05327 added the topic/ui Change the appearance of the Gitea UI label Aug 17, 2023

fix lint

b0e002f

delvh approved these changes Aug 17, 2023

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2023

wxiaoguang reviewed Aug 17, 2023

View reviewed changes

templates/repo/issue/card.tmpl Outdated Show resolved Hide resolved

Update templates/repo/issue/card.tmpl

3b23b2a

Co-authored-by: delvh <[email protected]>

silverwind reviewed Aug 18, 2023

View reviewed changes

puni9869 reviewed Aug 23, 2023

View reviewed changes

Merge branch 'main' into improve-issue-card

ebeb170

github-actions bot added the modifies/frontend label Oct 23, 2023

Merge branch 'main' into improve-issue-card

45220b9

silverwind removed the modifies/frontend label Mar 31, 2024

yp05327 mentioned this pull request May 9, 2024

Notes for Project-Board-Columns #29045

Open

5 tasks

yp05327 mentioned this pull request Jul 23, 2024

Project issues containing images overflow(-x) theirs columns #31667

Closed

SimonPistache mentioned this pull request Jul 23, 2024

Scroll images in project issues separately from the remaining issue #31683

Merged

yp05327 closed this Aug 12, 2024

GiteaBot mentioned this pull request Aug 12, 2024

Scroll images in project issues separately from the remaining issue (#31683) #31823

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve issue card #26561

Improve issue card #26561

yp05327 commented Aug 17, 2023

silverwind commented Aug 17, 2023

delvh commented Aug 17, 2023

silverwind commented Aug 17, 2023

silverwind commented Aug 17, 2023

silverwind Aug 18, 2023 •

edited

Loading

wxiaoguang Aug 21, 2023

silverwind Aug 23, 2023 •

edited

Loading

puni9869 Aug 23, 2023

delvh Aug 23, 2023

wxiaoguang Aug 23, 2023

silverwind commented May 10, 2024

yp05327 commented Aug 12, 2024

		<a {{if $.Page.PageIsProjects}}target="_blank"{{end}} href="{{$.Page.RepoLink}}/issues?labels={{.ID}}">{{RenderLabel ctx .}}</a>
		{{end}}

Improve issue card #26561

Improve issue card #26561

Conversation

yp05327 commented Aug 17, 2023

silverwind commented Aug 17, 2023

delvh commented Aug 17, 2023

silverwind commented Aug 17, 2023

silverwind commented Aug 17, 2023

silverwind Aug 18, 2023 • edited Loading

Choose a reason for hiding this comment

wxiaoguang Aug 21, 2023

Choose a reason for hiding this comment

silverwind Aug 23, 2023 • edited Loading

Choose a reason for hiding this comment

puni9869 Aug 23, 2023

Choose a reason for hiding this comment

delvh Aug 23, 2023

Choose a reason for hiding this comment

wxiaoguang Aug 23, 2023

Choose a reason for hiding this comment

silverwind commented May 10, 2024

yp05327 commented Aug 12, 2024

silverwind Aug 18, 2023 •

edited

Loading

silverwind Aug 23, 2023 •

edited

Loading