Add missing repository type filter parameters to pager #31832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
lunny
approved these changes
Aug 15, 2024
GiteaBot
added
lgtm/need 1
yp05327
changed the title
wolfogre
approved these changes
Aug 15, 2024
GiteaBot
added
lgtm/done
wolfogre
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Aug 15, 2024
Fix go-gitea#31807 ps: the newly added params's value will be changed. When the first time you selected the filter, the values of params will be `0` or `1` But in pager it will be `true` or `false`. So do we have `boolToInt` function?
GiteaBot
added
backport/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 16, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Add missing repository type filter parameters to pager (go-gitea#31832) Fix panic of ssh public key page after deletion of auth source (go-gitea#31829) [skip ci] Updated translations via Crowdin render plain text file if the LFS object doesn't exist (go-gitea#31812)
wolfogre
pushed a commit
that referenced
this pull request
Aug 16, 2024
Backport #31832 by @yp05327 Fix #31807 ps: the newly added params's value will be changed. When the first time you selected the filter, the values of params will be `0` or `1` But in pager it will be `true` or `false`. So do we have `boolToInt` function? Co-authored-by: yp05327 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31807
ps: the newly added params's value will be changed.
When the first time you selected the filter, the values of params will be
0or1But in pager it will be
trueorfalse.So do we have
boolToIntfunction?