Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code editor theme enhancements #31629

Merged
merged 5 commits into from
Jul 14, 2024
Merged

Code editor theme enhancements #31629

merged 5 commits into from
Jul 14, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jul 13, 2024 •
edited
Loading

  1. Fixed border-radius
  2. Monaco ignores the alpha channel on the shadow color, introduce color-shadow-opaque
  3. Remove scrollbar color which follows Remove scrollbar customizations #29800

Before:

Screenshot 2024-07-13 at 15 38 18 Screenshot 2024-07-13 at 15 38 31

After:

Screenshot 2024-07-13 at 15 38 06 Screenshot 2024-07-13 at 21 16 56

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 13, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 13, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jul 13, 2024
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 13, 2024
@silverwind silverwind changed the title Fix border-radius on code editor Code editor enhancements Jul 13, 2024
@silverwind silverwind changed the title Code editor enhancements Code editor theme enhancements Jul 13, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 14, 2024
@lafriks lafriks enabled auto-merge (squash) July 14, 2024 22:55
@lafriks lafriks merged commit 0bb4c1c into go-gitea:main Jul 14, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jul 14, 2024
@silverwind silverwind deleted the radius-editor branch July 15, 2024 09:04
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 16, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bf21df7 
* giteaofficial/main:
  Code editor theme enhancements (go-gitea#31629)
  Add option to change mail from user display name (go-gitea#31528)
  Upgrade xorm to v1.3.9 and improve some migrations Sync (go-gitea#29899)
  Issue Templates: add option to have dropdown printed list (go-gitea#31577)
  Fix update flake (go-gitea#31626)
silverwind added a commit to techknowlogick/gitea that referenced this pull request Jul 23, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into nolyfill
48fdc78 
* origin/main: (59 commits)
  fix OIDC introspection authentication (go-gitea#31632)
  Enable direnv (go-gitea#31672)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  fix redis dep (go-gitea#31662)
  add skip secondary authorization option for public oauth2 clients (go-gitea#31454)
  Fix a branch divergence cache bug (go-gitea#31659)
  [skip ci] Updated translations via Crowdin
  Remove unneccessary uses of `word-break: break-all` (go-gitea#31637)
  [skip ci] Updated translations via Crowdin
  Allow searching issues by ID (go-gitea#31479)
  allow synchronizing user status from OAuth2 login providers (go-gitea#31572)
  Enable `no-jquery/no-class-state` (go-gitea#31639)
  Added default sorting milestones by name (go-gitea#27084)
  Code editor theme enhancements (go-gitea#31629)
  Add option to change mail from user display name (go-gitea#31528)
  Upgrade xorm to v1.3.9 and improve some migrations Sync (go-gitea#29899)
  Issue Templates: add option to have dropdown printed list (go-gitea#31577)
  Fix update flake (go-gitea#31626)
  [skip ci] Updated translations via Crowdin
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @lunny @lafriks @GiteaBot