Upgrade xorm to v1.3.9 and improve some migrations Sync #29899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
modifies/go
delvh
reviewed
Mar 19, 2024
Comment on lines
+16
to
+22
| if _, err := x.SyncWithOptions(xorm.SyncOptions{ | ||
| IgnoreIndices: true, | ||
| IgnoreConstrains: true, | ||
| }, new(HookTask)); err != nil { | ||
| return err | ||
| } | ||
| _, err := x.Exec("UPDATE hook_task SET payload_version = 1 WHERE payload_version IS NULL") |
There was a problem hiding this comment.
I think we need to switch these statements around.
Otherwise, it seems inconsistent.
Why is it even necessary, even though it wasn't previously?
There was a problem hiding this comment.
This maybe an unrelated change to this PR. I just found v290 missed the update operations. Because creating a new column with default value will not update the old record automatically. It should be a bug of previous PR.
There was a problem hiding this comment.
Maybe split this change out into separate PR?
There was a problem hiding this comment.
I think fixing it here is fine ... just add a doctor command to address this things ?
silverwind
approved these changes
Mar 25, 2024
GiteaBot
added
lgtm/need 1
|
How to decide when to ignore indices and constrains? |
It depends on the context of the migration. If the migration just want to create a new index, then it can ignore deleting index. |
6543
approved these changes
Jul 12, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 16, 2024
* giteaofficial/main: Code editor theme enhancements (go-gitea#31629) Add option to change mail from user display name (go-gitea#31528) Upgrade xorm to v1.3.9 and improve some migrations Sync (go-gitea#29899) Issue Templates: add option to have dropdown printed list (go-gitea#31577) Fix update flake (go-gitea#31626)
silverwind
added a commit
to techknowlogick/gitea
that referenced
this pull request
Jul 23, 2024
* origin/main: (59 commits) fix OIDC introspection authentication (go-gitea#31632) Enable direnv (go-gitea#31672) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin fix redis dep (go-gitea#31662) add skip secondary authorization option for public oauth2 clients (go-gitea#31454) Fix a branch divergence cache bug (go-gitea#31659) [skip ci] Updated translations via Crowdin Remove unneccessary uses of `word-break: break-all` (go-gitea#31637) [skip ci] Updated translations via Crowdin Allow searching issues by ID (go-gitea#31479) allow synchronizing user status from OAuth2 login providers (go-gitea#31572) Enable `no-jquery/no-class-state` (go-gitea#31639) Added default sorting milestones by name (go-gitea#27084) Code editor theme enhancements (go-gitea#31629) Add option to change mail from user display name (go-gitea#31528) Upgrade xorm to v1.3.9 and improve some migrations Sync (go-gitea#29899) Issue Templates: add option to have dropdown printed list (go-gitea#31577) Fix update flake (go-gitea#31626) [skip ci] Updated translations via Crowdin ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.