Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added default sorting milestones by name #27084

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Added default sorting milestones by name #27084

merged 4 commits into from
Jul 16, 2024

Conversation

BElluu
Copy link
Contributor

@BElluu BElluu commented Sep 14, 2023

#26996
Added default sorting for milestones by name.
Additional, name for sorting closestduedate and furthestduedate was broken, so I fixed it.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 14, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 14, 2023
delvh
delvh requested changes Sep 14, 2023
View reviewed changes
models/issues/milestone_list.go Outdated Show resolved Hide resolved
models/issues/milestone_list.go Outdated Show resolved Hide resolved
templates/repo/issue/milestones.tmpl Outdated Show resolved Hide resolved
templates/user/dashboard/milestones.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 14, 2023
@BElluu
Copy link
Contributor Author

BElluu commented Sep 18, 2023

Hello :)
I reverted default sort, but still able to choose sorting by name :)
Thank you for your time!

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Jan 11, 2024
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/frontend modifies/docs modifies/migrations modifies/internal labels Jan 13, 2024
@lunny lunny force-pushed the 26996-sort-milestones-by-name branch from 43d5da4 to 49903e0 Compare January 15, 2024 07:56
@github-actions github-actions bot removed modifies/api This PR adds API routes or modifies them modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/frontend modifies/docs modifies/migrations modifies/internal labels Jan 15, 2024
@edav-mx
Copy link

edav-mx commented Jul 13, 2024 •
edited
Loading

Hi, is it possible to merge this to main? Or it might be better to separate the two issues this PR is addressing:

  • Name milestone sorting
  • Name for milestone sorting by closestduedate and furthestduedate

@6543
Copy link
Member

6543 commented Jul 13, 2024

Its fine but the conflicts need to be solved

@BElluu
Copy link
Contributor Author

BElluu commented Jul 14, 2024

Ouh PR last year :D I will fix this conflicts tomorrow :)

@6543
Copy link
Member

6543 commented Jul 14, 2024

sorry somethimes it gets lost till one picks it up again 😓

@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jul 15, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 15, 2024
@6543
Copy link
Member

6543 commented Jul 15, 2024

Just address tje lint issue and its good to go

@BElluu
Copy link
Contributor Author

BElluu commented Jul 15, 2024

I hope will be ok now, because I'm away from my PC with IDE, so I used edit file in github :)

@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 15, 2024
@edav-mx
Copy link

edav-mx commented Jul 16, 2024

Thanks to all.

@6543 6543 merged commit e8d4b7a into go-gitea:main Jul 16, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jul 16, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 16, 2024
@BElluu BElluu deleted the 26996-sort-milestones-by-name branch July 16, 2024 13:38
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 17, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
164e62d 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Allow searching issues by ID (go-gitea#31479)
  allow synchronizing user status from OAuth2 login providers (go-gitea#31572)
  Enable `no-jquery/no-class-state` (go-gitea#31639)
  Added default sorting milestones by name (go-gitea#27084)
silverwind added a commit to techknowlogick/gitea that referenced this pull request Jul 23, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into nolyfill
48fdc78 
* origin/main: (59 commits)
  fix OIDC introspection authentication (go-gitea#31632)
  Enable direnv (go-gitea#31672)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  fix redis dep (go-gitea#31662)
  add skip secondary authorization option for public oauth2 clients (go-gitea#31454)
  Fix a branch divergence cache bug (go-gitea#31659)
  [skip ci] Updated translations via Crowdin
  Remove unneccessary uses of `word-break: break-all` (go-gitea#31637)
  [skip ci] Updated translations via Crowdin
  Allow searching issues by ID (go-gitea#31479)
  allow synchronizing user status from OAuth2 login providers (go-gitea#31572)
  Enable `no-jquery/no-class-state` (go-gitea#31639)
  Added default sorting milestones by name (go-gitea#27084)
  Code editor theme enhancements (go-gitea#31629)
  Add option to change mail from user display name (go-gitea#31528)
  Upgrade xorm to v1.3.9 and improve some migrations Sync (go-gitea#29899)
  Issue Templates: add option to have dropdown printed list (go-gitea#31577)
  Fix update flake (go-gitea#31626)
  [skip ci] Updated translations via Crowdin
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny left review comments

@6543 6543 6543 approved these changes

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
7 participants
@BElluu @edav-mx @6543 @lunny @techknowlogick @delvh @GiteaBot