-
Notifications
You must be signed in to change notification settings - Fork 21
Support datasets with 4+ dimensions in the volume viewer #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This now depends on glue-viz/glue-qt#46. |
|
Very nice! Works great for me. Ping me once #396 is merged and this has been rebased and I'll do a careful review. |
|
@astrofrog Just rebased this. I've also added in the slice slider widgets to the Jupyter volume viewer (again following the example of the image viewer). |
…ecific axis indices (done a bit hackily for now).
…lation. Disable layer if not linked to reference x/y/z attrs.
|
@astrofrog Now that |
astrofrog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for working on this!
This PR updates the volume viewer to allow showing 3D slices of 4+ dimensional data, similar to how the image viewer can show 2D slices of 3+ dimensional data. In fact, the approach here is very much based on what the image viewer does. Below is a video of this in action.
Screen.Recording.2025-06-14.at.5.mp4
I built this on top of #396 to make sure that it was compatible, so that PR should be merged before this one. There are a couple of issues to maybe discuss/address here:
z_attin the 3D viewer. Maybe we should make this agetattr-style check in the glue-qt widget and then import that here?colororalphain the layer state will cause the viewer to think that its layers have changed and then reset the reference data. This is present in the current main branch as well, but doesn't seem to cause a problem there. However, I had to work around it here to prevent color/opacity changes from resetting slice indices.The test data in the video is something simple that I made in the glue terminal as follows: