Add support for stretches in volume viewer #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Added a widget to control the stretch to the Jupyter volume layer controls, so other than adding a test once we're happy with the functionality I don't think there's anything else I was planning to do with this. |
Carifio24
force-pushed
the
volume-stretches
branch
3 times, most recently
from
70e02a5 to
eae26c1
Compare
astrofrog
reviewed
Jun 3, 2025
Member
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
Works nicely! Let me know once this is rebased (once the other PR is merged) and I can review the actual code.
Member
|
@Carifio24 could you rebase this? |
Carifio24
force-pushed
the
volume-stretches
branch
from
eae26c1 to
8cba3a9
Compare
Member
Author
|
@astrofrog Just rebased |
astrofrog
requested changes
Jun 26, 2025
Member
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
Works nicely for me! Just a small comment about a rogue radio button which appears below the transparency slider.
| <item row="9" column="1"> | ||
| <widget class="QRadioButton" name="radio_subset_data"> | ||
| <property name="text"> | ||
| <string>Data</string> |
Member
There was a problem hiding this comment.
This radio button seems unrelated?
Member
Author
|
@astrofrog Got rid of that radio button, I think the UI widgets should be okay now |
This was referenced Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #395 and adds support for stretches for the volume viewer. This is done by creating a GLSL template string for each stretch type (which are stored in a
stretch_glslregistry so that a plugin can extend this functionality if it wants to). At least in my local testing,asinhwasn't a builtin GLSL function so this uses the log/sqrt expression for it.Marking this as a draft as I haven't set up the UI for the Jupyter volume viewer yet.