Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move activesupport to a development dependency #79

Merged
merged 1 commit into from
Aug 20, 2013

Conversation

jch
Copy link
Contributor

@jch jch commented Aug 20, 2013

It's used for instrumentation, but the requirement is only an object
that supports an ActiveSupport::Notification compatible interface. See
this section of the README
for details.

@jch
Copy link
Contributor Author

jch commented Aug 20, 2013

Fixes #76 also.

jch added a commit that referenced this pull request Aug 20, 2013
Move activesupport to a development dependency
@jch jch merged commit 5dddd7b into master Aug 20, 2013
@jch jch deleted the activesupport-development-dependency branch August 20, 2013 20:28
@mtodd
Copy link
Contributor

mtodd commented Aug 20, 2013

👍❤️

@mojavelinux
Copy link
Contributor

As I mentioned in #85, html-pipeline can no longer be used without activesupport installed. I've proposed a lighter-weight solution for satisfying the dependency on the mini_xml/nokogiri library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants