Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ActiveSupport 4 #76

Closed
spicycode opened this issue Aug 14, 2013 · 7 comments
Closed

Support for ActiveSupport 4 #76

spicycode opened this issue Aug 14, 2013 · 7 comments

Comments

@spicycode
Copy link
Contributor

We were upgrading from 0.0.14 to 0.2.0, but got blocked by the gemspec requirement on activesupport 3 or earlier.

Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    html-pipeline (~> 0.1.0) ruby depends on
      activesupport (< 4, >= 2) ruby

    rails (~> 4.0) ruby depends on
      activesupport (4.0.0)
@jch
Copy link
Contributor

jch commented Aug 14, 2013

Happy to take a pull to relax the requirement if you have time. Otherwise,
will be doing some hacking on this gem tomorrow evening anyways.

On Wednesday, August 14, 2013, Chad Humphries wrote:

We were upgrading from 0.0.14 to 0.2.0, but got blocked by the gemspec
requirement on activesupport 3 or earlier.

Bundler could not find compatible versions for gem "activesupport":
In Gemfile:
html-pipeline (~> 0.1.0) ruby depends on
activesupport (< 4, >= 2) ruby

rails (~> 4.0) ruby depends on
  activesupport (4.0.0)


Reply to this email directly or view it on GitHubhttps://github.com//issues/76
.

-Jerry
@whatcodecraves http://twitter.com/whatcodecraves
github https://github.com/jch

@spicycode
Copy link
Contributor Author

I'm likely not to have time until next week at this point. If it's still
open then I'll submit a PR.

On Wed, Aug 14, 2013 at 1:25 PM, Jerry Cheung [email protected]:

Happy to take a pull to relax the requirement if you have time. Otherwise,
will be doing some hacking on this gem tomorrow evening anyways.

On Wednesday, August 14, 2013, Chad Humphries wrote:

We were upgrading from 0.0.14 to 0.2.0, but got blocked by the gemspec
requirement on activesupport 3 or earlier.

Bundler could not find compatible versions for gem "activesupport":
In Gemfile:
html-pipeline (~> 0.1.0) ruby depends on
activesupport (< 4, >= 2) ruby

rails (~> 4.0) ruby depends on
activesupport (4.0.0)


Reply to this email directly or view it on GitHub<
https://github.com/jch/html-pipeline/issues/76>
.

-Jerry
@whatcodecraves http://twitter.com/whatcodecraves
github https://github.com/jch


Reply to this email directly or view it on GitHubhttps://github.com//issues/76#issuecomment-22652120
.

@spicycode
Copy link
Contributor Author

I've unpacked the gem after building locally and it looks like these version requirements are getting written in at build time. So if you build the gem with 1.9.3 or greater you get one set of requirements, 1.8.7 another, etc.

@jch
Copy link
Contributor

jch commented Aug 20, 2013

I'll take a look at this now, and get back to you.

jch pushed a commit that referenced this issue Aug 20, 2013
previously < 1.9.3, now < 1.9. Should fix #76
@jch
Copy link
Contributor

jch commented Aug 20, 2013

It looks like ActiveSupport requires a minimum of Ruby 1.9.3. What version of Ruby are you using?

@jch
Copy link
Contributor

jch commented Aug 20, 2013

Realized that ActiveSupport isn't even a hard dependency. I've moved it into a development dependency and cut 0.2.1. Feel free to reopen if it's still an issue for you.

@jch jch closed this as completed Aug 20, 2013
@spicycode
Copy link
Contributor Author

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants