use xml_mini extracted from activesupport #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mojavelinux ack, I missed that xml_mini dependency. Looking at the xml_mini gem, it doesn't look like it's officially been removed from activesupport. I would rather have the larger and more actively maintained activesupport dependency. Could you update your pull? |
|
Just to clarify, you do want to activesupport as a dependency instead of xml_mini? |
|
@mojavelinux 👍 yep, activesupport |
|
Roger that, captain! Pull request updated! |
jch
added a commit
that referenced
this pull request
Sep 18, 2013
use xml_mini extracted from activesupport
|
Thanks! I'll cut a gem when I get back to my computer. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to xml_mini gem to avoid runtime dependency on activesupport.