Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Conversation

mprins
Copy link
Contributor

@mprins mprins commented Oct 31, 2014

As proposed by some others, this works around the issue of not having a public email address on your github profile.

close #69
close #70
close #71
close #73
close #77

@joschi
Copy link

joschi commented Dec 14, 2014

👍

joschi added a commit to joschi/assertj-threetenbp that referenced this pull request Dec 14, 2014
joschi added a commit to joschi/jackson-datatype-threetenbp that referenced this pull request Dec 14, 2014
joschi added a commit to gini/dropwizard-gelf that referenced this pull request Dec 16, 2014
joschi added a commit to Graylog2/JadConfig that referenced this pull request Jan 7, 2015
joschi added a commit to dropwizard/dropwizard-java8 that referenced this pull request Jan 12, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use user.getEmail() when available and only fall back to userService.getEmails().get(0) when the first is null/empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that might work as well; you'd have to give it a try.
I don't know the specifics of of the egit api anymore and don't have time atm.

kevinsawicki added a commit that referenced this pull request Jan 21, 2015
workaround the case of a non-public email
@kevinsawicki kevinsawicki merged commit b561dc7 into github:master Jan 21, 2015
@kevinsawicki
Copy link
Contributor

Thanks for this, apologies for the delay

@kevinsawicki
Copy link
Contributor

Released 0.11 to Maven Central just now, thanks again.

@farolfo
Copy link

farolfo commented Jan 21, 2015

Thanks for this !!
I'm not finding the site-maven-plugin:0.11 version. This might be due to a delay in the release buckets?

@kevinsawicki
Copy link
Contributor

This might be due to a delay in the release buckets?

Yeah, I think it still takes hours to sync to maven central.

You can use https://oss.sonatype.org/#nexus-search;quick~github-maven-plugins in the interim if you need.

@mprins mprins deleted the non-public_email_fix branch January 22, 2015 09:49
joschi added a commit to dropwizard/dropwizard-flyway that referenced this pull request Mar 6, 2015
joschi added a commit to dropwizard/dropwizard-elasticsearch that referenced this pull request Mar 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

5 participants