Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

workaround the case of a non-public email #78

Merged
merged 1 commit into from
Jan 21, 2015
Merged

workaround the case of a non-public email #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion github-site-plugin/src/main/java/com/github/maven/plugins/site/SiteMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ public void execute() throws MojoExecutionException {

CommitUser author = new CommitUser();
author.setName(user.getName());
author.setEmail(user.getEmail());
author.setEmail(userService.getEmails().get(0));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this use user.getEmail() when available and only fall back to userService.getEmails().get(0) when the first is null/empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that might work as well; you'd have to give it a try.
I don't know the specifics of of the egit api anymore and don't have time atm.

author.setDate(new GregorianCalendar().getTime());

commit.setAuthor(author);
Expand Down