Error creating commit: Invalid request

[TheHolyWaffle]

[INFO] --- site-maven-plugin:0.9:site (execution1) @ lolchatapi ---
[INFO] Creating 18 blobs
[INFO] Creating tree with 19 blob entries
[INFO] Merging with tree 9a11f1f5c5d4e3441cb3949dcf9e907fa6c1f1d0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20.494 s
[INFO] Finished at: 2014-08-29T12:09:59+02:00
[INFO] Final Memory: 31M/267M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.github:site-maven-plugin:0.9:site (execution1) on project lolchatapi: Error creating commit: Invalid request.
[ERROR] 
[ERROR] Expected data to be of type "object"; value was: nil.
[ERROR] Expected data to be of type "object"; value was: nil. (422)

Expected data to be of type "object"; value was: nil.
Expected data to be of type "object"; value was: nil. (422)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
    at org.codehaus.classworlds.Launcher.main(Launcher.java:46)
Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating commit: Invalid request.

Expected data to be of type "object"; value was: nil.
Expected data to be of type "object"; value was: nil. (422)
    at com.github.maven.plugins.site.SiteMojo.execute(SiteMojo.java:440)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 20 more
Caused by: org.eclipse.egit.github.core.client.RequestException: Invalid request.

Expected data to be of type "object"; value was: nil.
Expected data to be of type "object"; value was: nil. (422)
    at org.eclipse.egit.github.core.client.GitHubClient.createException(GitHubClient.java:552)
    at org.eclipse.egit.github.core.client.GitHubClient.sendJson(GitHubClient.java:643)
    at org.eclipse.egit.github.core.client.GitHubClient.post(GitHubClient.java:757)
    at org.eclipse.egit.github.core.service.DataService.createCommit(DataService.java:397)
    at com.github.maven.plugins.site.SiteMojo.execute(SiteMojo.java:434)
    ... 22 more

Everything worked great 5 days ago, but today I started getting this error. Is there anything on my end that I can do?

[bguerin]

Same here

After some debug, I think it is because commit.getAuthor() and commit.getCommitter() are null

[TheHolyWaffle]

I believe so the same. Maybe it needs a setAuthor and setCommitter here : SiteMojo.java#L422-L424

[gtsntzs]

Hi

I have the same issue, did u fix it? Where do I place the setAuthor and/or commiter?

[TheHolyWaffle]

Haven't fixed it as I'm not familiar with Mojo's at all. I hope someone else can take a look at this.

[bguerin]

@TheHolyWaffle not fixed neither. I think the mojo can indeed ask for a commiter, but for compatibility purpose, I think the fix should rather be in the egit library (ie check if commiter / author is null before adding to JSON send to github API)

[bguerin]

See also #70

[yegor256]

Something has changed on Github server side, since everything worked fine three days ago. Maybe we should email them and ask for help?

[izuzak]

@yegor256 contacted us via support and I sent him an email in which I explained what I believe is the issue here.

I'm guessing that the process is creating Git trees via the Git Trees API:

https://developer.github.com/v3/git/trees/#create-a-tree

Notice that this API takes a base_tree as input, which should be a SHA of a tree object. However, up until recently the API was more forgiving about this field. Specifically, if you passed in a SHA of a commit (and not a SHA of a tree), the API detected this and fetched the SHA of the tree which the commit pointed to and used that as input. In other words, the API handled undocumented input in an expected way.

Recently, this behavior changed in the way that the API no longer supports this undocumented behavior. The error which the API is returning in this case is currently not very helpful (a 409 indicating that there's a problem with the repository), and that's a bug which will be fixed soon. Still, the process which is interacting with the API should be passing in the correct value as the base_tree -- it should be a SHA of a tree object, not a SHA of a commit object, as documented.

I'm really sorry that this is causing problems for you. Since this change didn't affect documented behavior, we didn't blog about it in advance.

@cescoffier @kevinsawicki -- my Java is weak, so heads up on this in case you can fix this or want to accept a pull request from someone in the community.

[bguerin]

Hello @izuzak

Thanks for posting here.
The issue we have does not seem to be what your describe. My debug run lead me to a 422 error code, not a 409

[izuzak]

Thanks @bguerin! Can you post the full request-response pair which is causing problems (an equivalent of a curl -v call)? That would be helpful in investigating this since the output above doesn't contain that information. Thanks!

(My hunch: I'm guessing that the 422 happens when the process tries to create a commit based on the response from a previously failed call to create a Git tree.)

[dgreenfield0]

Hey pplz,

I had the same error and fixed it by adding author and committer to the commit object. I am using the egit java client and via debugging found that it will send null values in the params to the github api if they are not set. Per the docs author and committer have the same keys. https://developer.github.com/v3/git/commits/

To note, when not initialized the author objects is sent with blank strings for email and name and null for date. The committer is simply sent as null.

hope this helps.

A snippet of my fix:
ex:
Commit commit = new Commit();
commit.setMessage(CommitTitle);
commit.setTree(tree);
CommitUser user = createCommitUser();
commit.setAuthor(user);
commit.setCommitter(user);
List listOfCommits = new ArrayList();
listOfCommits.add(new Commit().setSha(baseCommitSha));
commiteTest.setParents(listOfCommits);

public CommitUser createCommitUser(String email, String name) {
    CommitUser  cUser = new CommitUser();
    cUser.setEmail(email);
    cUser.setName(name);
    Format formatter = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS");
    Calendar now = Calendar.getInstance();
    cUser.setDate(now.getTime());
    return cUser;
}

[dgreenfield0]

Also, thanks @izuzak for the debug help and quick response. I had the 409 issue as well as the 422 error.
The 409 was per me using the incorrect sha value.

The 422 nil error was the author and committer issue (as described above).

To note, this is what the params looked like, when not instantiating the author and committer on the commit object.
{
"message": "Update",
"author": {
"name": "",
"email": "",
"date": null
},
"parents": [
"5bdec286c41258e16f1df7051c3df399e7080831"
],
"tree": "69f6ea6c5c023e3d2af9cb3eb0dfa10e31765f55"
"committer": null
}

[izuzak]

Ahhh, thanks @dgreenfield0 ❤️! Seems like this indeed isn't caused by the Git Trees API change after all, as @bguerin mentioned. A few other users were affected by those stricter validations today, so I jumped the 🔫 on this one. (Also, I only read the initial issue, not the other comments in which it was already figured out what the problem was -- really sorry about that and for the false alarm.)

[yegor256]

So, shall we submit a pull request to this maven plugin? What is the plan now? :)