Hackathons List Page #6297
Merged
Hackathons List Page #6297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walidmujahid
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6297 +/- ##
==========================================
+ Coverage 26.22% 26.24% +0.02%
==========================================
Files 296 296
Lines 29277 29294 +17
Branches 4323 4329 +6
==========================================
+ Hits 7677 7689 +12
- Misses 21329 21334 +5
Partials 271 271
Continue to review full report at Codecov.
|
walidmujahid
force-pushed
the
hackathon-project-page
branch
5 times, most recently
from
5a4fe46 to
3bc2faf
Compare
walidmujahid
force-pushed
the
hackathon-project-page
branch
6 times, most recently
from
aae78f3 to
18ab1cc
Compare
walidmujahid
force-pushed
the
hackathon-project-page
branch
from
12c2c1d to
d6667d6
Compare
walidmujahid
force-pushed
the
hackathon-project-page
branch
from
134dac3 to
16b171a
Compare
|
@walidmujahid You'll have to recreate your migrations. They are failing as is in Travis. If you have any issues, message me on Gitcoin Chat and I can help. |
walidmujahid
force-pushed
the
hackathon-project-page
branch
from
7987ded to
a3e313d
Compare
|
@androolloyd Okay, the migration problem is fixed. |
walidmujahid
force-pushed
the
hackathon-project-page
branch
from
a3e313d to
d00a709
Compare
|
I will update this with most recent master and recreate migrations. Has this been reveiwed @androolloyd? What changes are there that I need to make? |
|
I will have a look @walidmujahid |
add a third item to the tab tuple to act as title in views. previous version (title, count) new version (id, title, count) done so I do not have rework it too much. This way, the title can be variable and can be renamed fairly simply while the the id remains constant.
…kathon from model
walidmujahid
force-pushed
the
hackathon-project-page
branch
from
90bef2f to
0c3e3cd
Compare
danlipert
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo Video : https://youtu.be/pYi6Ul-Uvc0
Updsted Design - Copied checklist: #7096 (comment)
Happening Now tab:
Completed tab:
closes #7096
previous version
**Updated Demo Video - Full page with recent changes to hackathon section - 2020-06-11: https://youtu.be/rSdZAFy8gAc** Demo video - workshops section various device widths - 2020-06-09: https://youtu.be/WB7YmUwbBc4 Demo video - Workshops - 2020-06-07: https://youtu.be/C2M6hholtZc Demo of Progress from 2020-04-06 05:26: https://youtu.be/wKL6WvQ3SbsMain change on front end is update to margins for the boxes in the header.
Currently:
The boxes in the header can feature hackathons and the process to feature is shown in the video. When there is no featured hackathon, the header looksl like this:
The next section is the list of hackathons categorised as 'current', 'upcoming', and 'finished'. Each category can be navigated via the respective tabs. The 'current' tab is the default tab and if there are no 'current' hackathons then the 'upcoming' tab is the default if there are any, otherwise, the 'finished' tab is the default.
Next is the Tribes section where it shows all tribes that have posted prizes for all current hackathons. If there are no current hackathons but there exists upcoming hackathons, then tribes who had posted prizes in the most recently active hackathon are shown. If there are neither current nor upcoming hackathons, then the top four tribes are shown in order of the number of hackathons the respective tribes participated in.
Workshops will be added in a separate PR.Workshops added.Need to:
#6211