Update to Add styles and Hackathon project page #6569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: if no hackathon is ongoing, default to tribes who participated in the most number of hackathons. TODO: if no hackathon going, show tribes that most recently listed their bounties.
add rows to help space elements out properly and fix grid sizs.
if current hackathons exists, the tab is defaulted to current. if there are no current hackathons, the default tab is upcoming. otherwise, the default tab is finish.
`get_hackathon_event`, `get_tribe`, `tribe_fields`, and `hackathons_funded`
zoek1
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
|
@zoek1 + @walidmujahid can this be closed out ? |
|
@thelostone-mc Yes, #6297 has all the commits. I think 6569 can be closed? @zoek1? |
|
Thanks @zoek1! |
|
@zoek1 can we sort out travis? |
Everything is sorted on the original PR @androolloyd #6297 |
|
Sure, give a moment |
Codecov Report
@@ Coverage Diff @@
## master #6569 +/- ##
=======================================
Coverage 27.21% 27.21%
=======================================
Files 289 289
Lines 26798 26798
Branches 3962 3962
=======================================
Hits 7293 7293
Misses 19238 19238
Partials 267 267 Continue to review full report at Codecov.
|
|
Perfect @walidmujahid integrated my changes 🙌 Lets with #6297! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original work Hackathon Project Page #6297
Minor error fixes and fix styles on the mobile view.
To move this fast I fixed some error on indexing and also fix some styles on mobile view, thanks to @walidmujahid for his awesome work on this feature.
Refers/Fixes
Testing