Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hackathon list page loadtime #7254

Merged

Conversation

walidmujahid
Copy link
Contributor

@walidmujahid walidmujahid commented Aug 19, 2020

Have context loaded from perftools.models.JSONStore. Updates whenever create_page_cache management command runs.

refers #6297 (comment)

@walidmujahid walidmujahid mentioned this pull request Aug 19, 2020
9 tasks
@walidmujahid walidmujahid force-pushed the fix-hackathon-list-page-loadtime branch from 040c815 to 8831880 Compare August 21, 2020 13:41
@walidmujahid walidmujahid marked this pull request as ready for review August 21, 2020 13:45
@walidmujahid
Copy link
Contributor Author

@thelostone-mc @owocki

I have been testing this locally, however, I am not sure how much of a performance boost has been given or if the the problem was solved at all.

@owocki
Copy link
Contributor

owocki commented Aug 21, 2020 via email

@walidmujahid walidmujahid force-pushed the fix-hackathon-list-page-loadtime branch from 8831880 to 5893480 Compare August 21, 2020 14:01
@walidmujahid
Copy link
Contributor Author

walidmujahid commented Aug 21, 2020

can i see the WIP PR ur testing? i have a prod backup locally + can test there

It is this current PR @owocki

@walidmujahid walidmujahid changed the title Fix hackathon list page loadtime [WIP] Fix hackathon list page loadtime Aug 21, 2020
@owocki
Copy link
Contributor

owocki commented Aug 21, 2020

on my local (witha prod backup)

kevinowocki@local /Users/kevinowocki~ % time curl http://localhost:8000/hackathon > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  176k  100  176k    0     0   267k      0 --:--:-- --:--:-- --:--:--  267k
curl http://localhost:8000/hackathon > /dev/null  0.00s user 0.01s system 2% cpu 0.673 total

very nice!

@walidmujahid
Copy link
Contributor Author

on my local (witha prod backup)

kevinowocki@local /Users/kevinowocki~ % time curl http://localhost:8000/hackathon > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  176k  100  176k    0     0   267k      0 --:--:-- --:--:-- --:--:--  267k
curl http://localhost:8000/hackathon > /dev/null  0.00s user 0.01s system 2% cpu 0.673 total

very nice!

Good to hear. I assume then this does well in resolving this #6297 (comment)

I have been also running performance tests and running lighthouse -both in localhost and for live site- and it seems that the payload and unused scripts might also be causing loadtime issues. However, I am not sure what kind of solutions others may be considering especially since alot of scripts that could be deferred or not of primaery importance to this specific page are also shared scripts on other sections of the site.

@walidmujahid walidmujahid changed the title [WIP] Fix hackathon list page loadtime [ix hackathon list page loadtime Aug 21, 2020
@walidmujahid walidmujahid changed the title [ix hackathon list page loadtime Fix hackathon list page loadtime Aug 21, 2020
@thelostone-mc
Copy link
Member

Just skimmed through the code ! Oh this I like :D

@thelostone-mc thelostone-mc merged commit 6bcbf73 into gitcoinco:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants