ui: Refactor Built-In Tools naming (Server/Browser)

[allozaur]

Overview

Simple naming refactor introducing separation of built-in tools to Server and Browser categories.

Requirements

• I have read and agree with the contributing guidelines
• AI usage disclosure: YES, DeepSeek V4 Flash 0731 with Pi

[Copilot]

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Refactors the UI and server naming around “built-in tools” to a clearer separation of Server vs Browser tool categories, updating identifiers, labels, and UI metadata plumbing accordingly.

Changes:

• Renamed tool source identifiers (builtin/frontend → server/browser) and updated UI group labels/strings.
• Updated tool name enum entries to SERVER_*/BROWSER_* variants and adjusted call sites/tests.
• Replaced getBuiltinToolUi + BUILTIN_TOOL_UI with a unified getToolUi + TOOL_UI registry.

Reviewed changes

Copilot reviewed 47 out of 49 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tools/ui/src/lib/stores/tools.svelte.ts	Renames internal tool lists/keys/sources from builtin/frontend to server/browser and fetches server tools from /tools.
tools/ui/src/lib/enums/tools.enums.ts	Updates ToolSource values and introduces prefixed BuiltInTool entries for server vs browser tools.
tools/ui/src/lib/constants/tool-ui.constants.ts	Adds unified UI metadata registry (TOOL_UI) for server and browser tools.
tools/ui/src/lib/utils/tool-ui.ts	Adds unified helper getToolUi() used by tool-call chrome & settings UI.
tools/server/server-tools.h	Changes tool type() string from "builtin" to "server" (affects /tools wire payload).
tools/server/README*.md	Updates documentation terminology from built-in → server tools.
tools/ui/tests/*	Updates tests to use new tool names and new key prefix (server:).

Suppressed comments (3)

tools/ui/src/lib/stores/tools.svelte.ts:1

• If /tools returns both server and MCP tools (as described in tools/server/README-dev.md), this code will incorrectly treat MCP tools as server tools (loading them into _serverTools, marking cwd awareness, and later generating server: keys). Filter toolInfos to info.type === ToolSource.SERVER before populating _serverTools/_cwdAwareTools, and leave MCP tools to mcpStore to avoid duplicates/misclassification.
  tools/ui/src/lib/stores/tools.svelte.ts:1
• This changes the persisted/stable key format from builtin:/frontend: to server:/browser:. Existing users’ localStorage entries (disabled tool keys and any permission keys stored elsewhere) will no longer match, effectively re-enabling tools/resetting selections after upgrade. Consider adding a small migration in the localStorage load path (e.g., rewrite builtin: → server: and frontend: → browser: when reading the disabled set) to preserve user settings across versions.
  tools/ui/src/lib/utils/tool-ui.ts:1
• Casting TOOL_UI to Record<string, ToolUiEntry> weakens type safety and can hide mismatches between tool names and the registry keys. Prefer narrowing toolName to the actual key type (e.g., accept toolName: BuiltInTool | undefined, or use a runtime in check with a typed helper) so missing/renamed tool IDs are caught during refactors.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.