Skip to content

ci : push release tag explicitly in release.yml - #27261

Merged
ggerganov merged 1 commit into
masterfrom
gg/release-explicit-tag
Aug 17, 2026
Merged

ci : push release tag explicitly in release.yml#27261
ggerganov merged 1 commit into
masterfrom
gg/release-explicit-tag

Conversation

@ggerganov

@ggerganov ggerganov commented Aug 17, 2026

Copy link
Copy Markdown
Member

Overview

The release job in release.yml currently creates the b<number> tag implicitly — as a side effect of ggml-org/action-create-release calling the "Create a Release" REST API (which creates the tag at target_commitish if it does not exist).

This PR makes it explicit: a new Create and push git tag step in the release job (right before Create release) creates the tag with git tag and pushes it using the DEPLOY_KEY_RELEASE deploy key already configured by the Clone step. When the release action runs, the tag already exists, so the API only attaches the release to it.

Behavior change to note: tag and release are no longer created atomically by the API. If the release-creation step fails, the tag will remain on the repo without a release (a re-run skips tag creation and retries the release).

Should fix: https://github.com/ggml-org/llama.cpp/actions/runs/32026925108/job/95389714411#step:8:158

Requirements

Add a "Create and push git tag" step to the release job, right before
the "Create release" step. The tag is created with git tag and pushed
with the deploy key already configured by the Clone step, instead of
relying on the Releases API (action-create-release) to create it as a
side effect.

The tag is lightweight, matching all existing b<number> release tags.
The step is idempotent: if the tag already exists (e.g. on a re-run),
creation and push are skipped.

Assisted-by: pi:llama.cpp/Qwen3.8-27B
@ggerganov
ggerganov marked this pull request as ready for review August 17, 2026 13:06
@ggerganov
ggerganov requested a review from a team as a code owner August 17, 2026 13:06
@ggerganov
ggerganov merged commit 34af94c into master Aug 17, 2026
3 checks passed
@ggerganov
ggerganov deleted the gg/release-explicit-tag branch August 17, 2026 13:14
@github-actions github-actions Bot added the devops improvements to build systems and github actions label Aug 17, 2026
gabe-l-hart added a commit to gabe-l-hart/llama.cpp that referenced this pull request Aug 17, 2026
* origin/master: (86 commits)
ui: enforce alphabetical enum member ordering (ggml-org#27272)
ui: Refactor Built-In Tools naming (Server/Browser) (ggml-org#27271)
ci: more optimizations (ggml-org#26983)
doc: document MCP stdio servers and CORS defaults in the server README [no release] [no ci] (ggml-org#26847)
server: save processed mtmd chunks as placeholder (ggml-org#27278)
mtmd: use sha256 for input hashing (ggml-org#27274)
vocab : support integer tokenizer scores (ggml-org#27260)
mtmd : skip thumbnail for non-tiled LFM2 images (ggml-org#27246)
cuda : skip UMA override for HIP builds (ggml-org#27083)
vendor: move hash to vendor (ggml-org#27262)
ci : push release tag explicitly in release.yml (ggml-org#27261)
ui: move get_datetime tool to frontend (ggml-org#27255)
ci : reduce builds in build-xcframework.sh (ggml-org#27252)
model: support speculators-format checkpoints for DSpark (ggml-org#26275)
ui: add browser get_info tool (ggml-org#27251)
ci : restore release.yml check during make-release.yml (ggml-org#27247)
mtmd: harden preprocessor_granite (ggml-org#27235)
ci : allow make-release to target a specific commit (ggml-org#27234)
ci : make release workflows use a deploy key (ggml-org#27229)
convert: add @ModelBase.example (ggml-org#27208)
...
brittlewis12 pushed a commit to brittlewis12/llama.cpp that referenced this pull request Aug 17, 2026
Add a "Create and push git tag" step to the release job, right before
the "Create release" step. The tag is created with git tag and pushed
with the deploy key already configured by the Clone step, instead of
relying on the Releases API (action-create-release) to create it as a
side effect.

The tag is lightweight, matching all existing b<number> release tags.
The step is idempotent: if the tag already exists (e.g. on a re-run),
creation and push are skipped.

Assisted-by: pi:llama.cpp/Qwen3.8-27B
@veox

veox commented Aug 17, 2026

Copy link
Copy Markdown

Looks like some extra tags made it to origin (this repo) during testing:

https://github.com/ggml-org/llama.cpp/tags

Screenshot:

Screenshot 2026-08-18 at 02-18-04 Tags · ggml-org_llama cpp

Or was the 0.1.1 part intentional?.. A local build now reports (Arch Linux, via AUR llama.cpp-vulkan-git package):

% llama-cli --version
version: 0.1.1-dev (build 10470, commit 34af94cd9ab277632e27caeec2d41de2fd091b31)
built with GNU 16.2.1 for Linux x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants