Skip to content

mtmd : skip thumbnail for non-tiled LFM2 images - #27246

Merged
ngxson merged 2 commits into
ggml-org:masterfrom
tdakhran:tarek/feat/lfm-fix-overview
Aug 17, 2026
Merged

mtmd : skip thumbnail for non-tiled LFM2 images#27246
ngxson merged 2 commits into
ggml-org:masterfrom
tdakhran:tarek/feat/lfm-fix-overview

Conversation

@tdakhran

Copy link
Copy Markdown
Contributor

Overview

Fix tiling logic to match HF behavior, particularly do not add an overview/thumbnail when there is no tiling.

Additional information

Together with #27057 matches HF behavior with and without tiling.

Requirements

@tdakhran
tdakhran requested a review from a team as a code owner August 17, 2026 09:36
@github-actions github-actions Bot added the mtmd Related to multimodal functionality (video/image/audio) label Aug 17, 2026
ngxson
ngxson previously approved these changes Aug 17, 2026
Comment thread tools/mtmd/mtmd-image.cpp
@ngxson
ngxson dismissed their stale review August 17, 2026 11:23

mtmd_image_preproc_out:overview question

@ngxson
ngxson merged commit b75ecd1 into ggml-org:master Aug 17, 2026
25 of 27 checks passed
gabe-l-hart added a commit to gabe-l-hart/llama.cpp that referenced this pull request Aug 17, 2026
* origin/master: (86 commits)
ui: enforce alphabetical enum member ordering (ggml-org#27272)
ui: Refactor Built-In Tools naming (Server/Browser) (ggml-org#27271)
ci: more optimizations (ggml-org#26983)
doc: document MCP stdio servers and CORS defaults in the server README [no release] [no ci] (ggml-org#26847)
server: save processed mtmd chunks as placeholder (ggml-org#27278)
mtmd: use sha256 for input hashing (ggml-org#27274)
vocab : support integer tokenizer scores (ggml-org#27260)
mtmd : skip thumbnail for non-tiled LFM2 images (ggml-org#27246)
cuda : skip UMA override for HIP builds (ggml-org#27083)
vendor: move hash to vendor (ggml-org#27262)
ci : push release tag explicitly in release.yml (ggml-org#27261)
ui: move get_datetime tool to frontend (ggml-org#27255)
ci : reduce builds in build-xcframework.sh (ggml-org#27252)
model: support speculators-format checkpoints for DSpark (ggml-org#26275)
ui: add browser get_info tool (ggml-org#27251)
ci : restore release.yml check during make-release.yml (ggml-org#27247)
mtmd: harden preprocessor_granite (ggml-org#27235)
ci : allow make-release to target a specific commit (ggml-org#27234)
ci : make release workflows use a deploy key (ggml-org#27229)
convert: add @ModelBase.example (ggml-org#27208)
...
brittlewis12 pushed a commit to brittlewis12/llama.cpp that referenced this pull request Aug 17, 2026
* mtmd : skip thumbnail for non-tiled LFM2 images

Matches HF behavior.

* Update tools/mtmd/mtmd-image.cpp

---------

Co-authored-by: Xuan-Son Nguyen <thichthat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mtmd Related to multimodal functionality (video/image/audio)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants