Check for attachment overlap using textures, not views #8402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleiserson
force-pushed
the
push-xowpsnpytynp
branch
from
b41191a to
2cc0b94
Compare
andyleiserson
force-pushed
the
push-xowpsnpytynp
branch
from
2cc0b94 to
7f8e8dd
Compare
andyleiserson
added a commit
to andyleiserson/wgpu
that referenced
this pull request
Nov 6, 2025
This was a regression introduced by gfx-rs#8307. (The failured referred to by "fails due to missing validation" was fixed before the regression, by gfx-rs#8402, but was not identified as fixed and added to the test list at that time.)
6 tasks
1 task
andyleiserson
added a commit
that referenced
this pull request
Nov 7, 2025
This was a regression introduced by #8307. For mipmapped multi-planar textures, requires that the size is a multiple of a power of two determined by the mip level count, in lieu of properly aligning the size of each mip level to an even dimension. See #8491. (The failure referred to by "fails due to missing validation" was fixed before the regression, by #8402, but was not identified as fixed and added to the test list at that time.)
andyleiserson
added a commit
that referenced
this pull request
Nov 7, 2025
This was a regression introduced by #8307. For mipmapped multi-planar textures, requires that the size is a multiple of a power of two determined by the mip level count, in lieu of properly aligning the size of each mip level to an even dimension. See #8491. (The failure referred to by "fails due to missing validation" was fixed before the regression, by #8402, but was not identified as fixed and added to the test list at that time.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overlap of color attachments should be computed based on the actual texture resources, not the views used to reference them.
Fixes failure of the CTS test
webgpu:api,validation,resource_usages,texture,in_pass_encoder:subresources_and_binding_types_combination_for_color:compute=false;type0="render-target";type1="render-target".Partially addresses #3126.
Testing
Enables relevant CTS test.
Squash or Rebase? Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.