Correct STORAGE_READ_ONLY exclusivity #8490
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
approved these changes
Nov 6, 2025
Member
ErichDonGubler
left a comment
ErichDonGubler
left a comment
There was a problem hiding this comment.
LGTM overall, just a couple of nits.
CHANGELOG.md
Outdated
| - Removed three features from `wgpu-hal` which did nothing useful: `"cargo-clippy"`, `"gpu-allocator"`, and `"rustc-hash"`. By @kpreid in [#8357](https://github.com/gfx-rs/wgpu/pull/8357). | ||
| - `wgpu_types::PollError` now always implements the `Error` trait. By @kpreid in [#8384](https://github.com/gfx-rs/wgpu/pull/8384). | ||
| - The texture subresources used by the color attachments of a render pass are no longer allowed to overlap when accessed via different texture views. By @andyleiserson in [#8402](https://github.com/gfx-rs/wgpu/pull/8402). | ||
| - The `STORAGE_READ_ONLY` texture usage is now permitted to coexist with other read-only usages. By @andyleiserson in TBD. |
Member
Contributor
Author
There was a problem hiding this comment.
The scope of this change isn't a subset of what was affected by the previous change. If there was a conflict between storage-read and constant usage of the same texture view, that would have been rejected even before the previous change, and is now allowed.
That said, it's definitely a minor change, and given that it's been wrong forever without getting noticed, there's a good chance nobody seeing it in the change log will care. But it still seemed like it qualified to be noted in the change log as a bug fix with a distinct user-visible behavior change.
andyleiserson
force-pushed
the
push-uzpruuynlxmv
branch
from
83e5bc1 to
065e1cd
Compare
andyleiserson
added a commit
that referenced
this pull request
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8485
Testing
Adds CTS tests
Squash or Rebase? Squash