Mesh shaders: implement for Vulkan backend #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
kvark
requested changes
May 9, 2020
kvark
requested changes
May 9, 2020
src/backend/vulkan/src/lib.rs
Outdated
| @@ -1081,6 +1098,9 @@ impl adapter::PhysicalDevice<Backend> for PhysicalDevice { | |||
| if features.inherited_queries != 0 { | |||
| bits |= Features::INHERITED_QUERIES; | |||
| } | |||
| if self.supports_extension(*MESH_SHADER) { | |||
| bits |= Features::MESH_SHADER; | |||
There was a problem hiding this comment.
Added. Can't be separated without VkPhysicalFeatures2. Most probably inconsequential as DirectX 12 requires both shaders to be supported despite Task being optional in the pipeline as well as in the Vulkan extension itself.
some fixes fix some review notes
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes an example.
To discuss\resolve:
mesh_fnadded toRawDevice. Is it ok? Will It stay ok being extended with many more extensions?pNextmember to some structs that should have had one. This includes VkPhysicalProperties. Without Vulkan 1.1(or KHR extension) where this was remedied, we are unable to query for limits of the mesh shader extension that are inside VkPhysicalDeviceMeshShaderPropertiesNV struct.PR checklist:
makesucceeds (on *nix)make reftestssucceedsrustfmtrun on changed code