-
-
Notifications
You must be signed in to change notification settings - Fork 372
refactor: Update max attachment size in Sentry options #6726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update max attachment size in Sentry options #6726
Conversation
Updates the maximum attachment size limit to align with the latest Sentry relay limits as documented in: https://develop.sentry.dev/sdk/data-model/envelopes/#size-limits Changes: - Increased maxAttachmentSize default from 100MB to 200MB - Updated documentation in SentryOptions.h - Updated unit tests in SentryOptionsTest.m This change supports the following envelope size limits: - 40MB for compressed envelope requests - 200MB for full envelope after decompression - 200MB for all attachments combined - 200MB for each individual attachment item Relates to: #6537
|
Cursor Agent can help with this pull request. Just |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6726 +/- ##
=============================================
+ Coverage 85.051% 85.069% +0.018%
=============================================
Files 452 452
Lines 27649 27649
Branches 12144 12144
=============================================
+ Hits 23516 23521 +5
+ Misses 4087 4085 -2
+ Partials 46 43 -3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this PR definitely deserves a changelog entry.
…achment-size-in-sentry-options-5dfe
Removed duplicate entry for increasing maximum attachment size.
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4a7a005 | 1229.15 ms | 1243.35 ms | 14.20 ms |
| 5b44596 | 1220.87 ms | 1247.27 ms | 26.40 ms |
| 2137530 | 1223.39 ms | 1253.25 ms | 29.86 ms |
| 32f2329 | 1224.36 ms | 1257.33 ms | 32.98 ms |
| b9c733a | 1195.49 ms | 1220.23 ms | 24.74 ms |
| c8420eb | 1214.16 ms | 1246.22 ms | 32.06 ms |
| 492686a | 1230.82 ms | 1255.82 ms | 25.00 ms |
| 72a8746 | 1215.23 ms | 1259.22 ms | 43.99 ms |
| 51f74d7 | 1236.31 ms | 1247.43 ms | 11.12 ms |
| e9f483c | 1224.60 ms | 1260.00 ms | 35.40 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4a7a005 | 23.75 KiB | 979.96 KiB | 956.22 KiB |
| 5b44596 | 23.75 KiB | 1.00 MiB | 1002.41 KiB |
| 2137530 | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| 32f2329 | 23.75 KiB | 1.01 MiB | 1016.02 KiB |
| b9c733a | 23.74 KiB | 1021.49 KiB | 997.74 KiB |
| c8420eb | 23.75 KiB | 995.83 KiB | 972.09 KiB |
| 492686a | 23.75 KiB | 1.01 MiB | 1016.13 KiB |
| 72a8746 | 23.74 KiB | 976.79 KiB | 953.05 KiB |
| 51f74d7 | 23.74 KiB | 874.08 KiB | 850.34 KiB |
| e9f483c | 23.75 KiB | 1022.77 KiB | 999.03 KiB |
📜 Description
Bumps the
maxAttachmentSizeinSentryOptionsfrom 100MB to 200MB.💡 Motivation and Context
This change aligns the SDK's default
maxAttachmentSizewith the updated Sentry relay limits. The new limits are: 40MB for a compressed envelope request, 200MB for a full envelope after decompression, 200MB for all attachments combined, and 200MB for each individual attachment item. This update prevents attachments from being unnecessarily discarded by the relay.Fixes #6537
💚 How did you test it?
Updated existing unit tests in
SentryOptionsTest.mto reflect the new default value and verified they pass.📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.Slack Thread