Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Oct 24, 2025

In accordance to #5913, increase the maximum attachment size

Part of #5913

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.536%. Comparing base (707c222) to head (d4b35aa).
⚠️ Report is 23 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6537       +/-   ##
=============================================
- Coverage   85.899%   85.536%   -0.364%     
=============================================
  Files          451       451               
  Lines        27482     27428       -54     
  Branches     11970     11936       -34     
=============================================
- Hits         23607     23461      -146     
- Misses        3826      3922       +96     
+ Partials        49        45        -4     
Files with missing lines Coverage Δ
Sources/Sentry/SentryOptions.m 96.491% <100.000%> (-0.554%) ⬇️

... and 90 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707c222...d4b35aa. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1201.76 ms 1224.69 ms 22.93 ms
Size 23.75 KiB 1.01 MiB 1016.13 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
748df9d 1231.63 ms 1259.47 ms 27.84 ms
13bc1aa 1244.04 ms 1262.89 ms 18.85 ms
aa0b738 1236.78 ms 1253.08 ms 16.31 ms
dba2de8 1231.45 ms 1251.88 ms 20.43 ms
9be5373 1215.92 ms 1239.44 ms 23.52 ms
ef2c9b3 1222.12 ms 1253.96 ms 31.84 ms
7bd90de 1233.48 ms 1249.47 ms 15.99 ms
53b722c 1222.33 ms 1244.90 ms 22.56 ms
a6f5396 1211.81 ms 1245.63 ms 33.82 ms
62f8d2a 1226.24 ms 1249.92 ms 23.67 ms

App size

Revision Plain With Sentry Diff
748df9d 23.75 KiB 902.48 KiB 878.74 KiB
13bc1aa 23.75 KiB 908.40 KiB 884.65 KiB
aa0b738 23.74 KiB 872.75 KiB 849.00 KiB
dba2de8 23.75 KiB 969.25 KiB 945.50 KiB
9be5373 23.75 KiB 866.50 KiB 842.75 KiB
ef2c9b3 23.75 KiB 933.03 KiB 909.29 KiB
7bd90de 23.75 KiB 933.33 KiB 909.58 KiB
53b722c 23.75 KiB 906.08 KiB 882.33 KiB
a6f5396 23.75 KiB 989.12 KiB 965.38 KiB
62f8d2a 23.75 KiB 926.80 KiB 903.05 KiB

Previous results on branch: itay/increase_attachment_size

Startup times

Revision Plain With Sentry Diff
9f5b838 1233.18 ms 1242.29 ms 9.11 ms
752f396 1196.44 ms 1224.96 ms 28.52 ms

App size

Revision Plain With Sentry Diff
9f5b838 23.75 KiB 1.00 MiB 1005.08 KiB
752f396 23.75 KiB 1.00 MiB 1002.40 KiB

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for tackling this.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update this public code comment

/**
* The maximum size for each attachment in bytes.
* @note Default is 20 MiB (20 ✕ 1024 ✕ 1024 bytes).
* @note Please also check the maximum attachment size of relay to make sure your attachments don't
* get discarded there:
* https://docs.sentry.io/product/relay/options/
*/
@property (nonatomic, assign) NSUInteger maxAttachmentSize;

Thanks

@itaybre itaybre enabled auto-merge (squash) October 29, 2025 12:58
@itaybre itaybre merged commit e81ca14 into main Oct 29, 2025
263 of 277 checks passed
@itaybre itaybre deleted the itay/increase_attachment_size branch October 29, 2025 17:07
cursor bot pushed a commit that referenced this pull request Nov 10, 2025
Updates the maximum attachment size limit to align with the latest
Sentry relay limits as documented in:
https://develop.sentry.dev/sdk/data-model/envelopes/#size-limits

Changes:
- Increased maxAttachmentSize default from 100MB to 200MB
- Updated documentation in SentryOptions.h
- Updated unit tests in SentryOptionsTest.m

This change supports the following envelope size limits:
- 40MB for compressed envelope requests
- 200MB for full envelope after decompression
- 200MB for all attachments combined
- 200MB for each individual attachment item

Relates to: #6537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants