Skip to content

refactor: Update max attachment size in Sentry options #6726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 12, 2025
Merged

refactor: Update max attachment size in Sentry options #6726

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
667edb2
Update maxAttachmentSize from 100MB to 200MB
cursoragent Nov 10, 2025
382a86a
Merge remote-tracking branch 'origin/main' into cursor/update-max-att…
philprime Nov 11, 2025
f77a8eb
update changelog
philprime Nov 11, 2025
326300e
Merge branch 'main' into cursor/update-max-attachment-size-in-sentry-…
philprime Nov 12, 2025
ff79bcf
Remove duplicate changelog entry for attachment size
philprime Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Sentry/Public/SentryOptions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ NS_SWIFT_NAME(Options)

/**
* The maximum size for each attachment in bytes.
* @note Default is 100 MiB (100 ✕ 1024 ✕ 1024 bytes).
* @note Default is 200 MiB (200 ✕ 1024 ✕ 1024 bytes).
* @note Please also check the maximum attachment size of relay to make sure your attachments don't
* get discarded there:
* https://docs.sentry.io/product/relay/options/
Expand Down
4 changes: 2 additions & 2 deletions Sources/Sentry/SentryOptions.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ - (instancetype)init
self.enableWatchdogTerminationTracking = YES;
self.sessionTrackingIntervalMillis = [@30000 unsignedIntValue];
self.attachStacktrace = YES;
// Maximum attachment size is 100 MiB, matches Relay's limit:
// Maximum attachment size is 200 MiB, matches Relay's limit:
// https://develop.sentry.dev/sdk/data-model/envelopes/#size-limits
self.maxAttachmentSize = 100 * 1024 * 1024;
self.maxAttachmentSize = 200 * 1024 * 1024;
self.sendDefaultPii = NO;
self.enableAutoPerformanceTracing = YES;
self.enablePersistingTracesWhenCrashing = NO;
Expand Down
4 changes: 2 additions & 2 deletions Tests/SentryTests/SentryOptionsTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,7 @@ - (void)assertDefaultValues:(SentryOptions *)options
XCTAssertEqual(YES, options.enableWatchdogTerminationTracking);
XCTAssertEqual([@30000 unsignedIntValue], options.sessionTrackingIntervalMillis);
XCTAssertEqual(YES, options.attachStacktrace);
XCTAssertEqual(100 * 1024 * 1024, options.maxAttachmentSize);
XCTAssertEqual(200 * 1024 * 1024, options.maxAttachmentSize);
XCTAssertEqual(NO, options.sendDefaultPii);
XCTAssertTrue(options.enableAutoPerformanceTracing);
#if SENTRY_HAS_UIKIT
Expand Down Expand Up @@ -805,7 +805,7 @@ - (void)testDefaultMaxAttachmentSize
{
SentryOptions *options = [self getValidOptions:@{}];

XCTAssertEqual(100 * 1024 * 1024, options.maxAttachmentSize);
XCTAssertEqual(200 * 1024 * 1024, options.maxAttachmentSize);
}

- (void)testSendDefaultPii
Expand Down
Loading