Skip to content

test: explicitly set code coverage to true in all test plans #5544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025
Merged

test: explicitly set code coverage to true in all test plans #5544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Plans/SentrySwiftUI_Base.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : true,
"uiTestingScreenshotsLifetime" : "keepAlways"
},
"testTargets" : [
Expand Down
1 change: 1 addition & 0 deletions Plans/Sentry_Base.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : true,
"environmentVariableEntries" : [
{
"key" : "TSAN_OPTIONS",
Expand Down
1 change: 1 addition & 0 deletions Plans/SwiftUITestSample_Base.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : true,
"uiTestingScreenshotsLifetime" : "keepAlways"
},
"testTargets" : [
Expand Down
1 change: 1 addition & 0 deletions Plans/iOS-ObjectiveC_Base.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : true,
"uiTestingScreenshotsLifetime" : "keepAlways"
},
"testTargets" : [
Expand Down
1 change: 1 addition & 0 deletions Plans/iOS-Swift6_Base.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : true,
"uiTestingScreenshotsLifetime" : "keepAlways"
},
"testTargets" : [
Expand Down
2 changes: 1 addition & 1 deletion Plans/iOS-SwiftUI_Base.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
"codeCoverage" : true,
"targetForVariableExpansion" : {
"containerPath" : "container:iOS-SwiftUI.xcodeproj",
"identifier" : "7BB6224826A56C4E00D0E75E",
Expand Down
1 change: 1 addition & 0 deletions Plans/iOS-Swift_Base.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : true,
"targetForVariableExpansion" : {
"containerPath" : "container:iOS-Swift.xcodeproj",
"identifier" : "637AFDA5243B02760034958B",
Expand Down
2 changes: 1 addition & 1 deletion Plans/iOS13-Swift_Base.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
"codeCoverage" : true,
"targetForVariableExpansion" : {
"containerPath" : "container:iOS13-Swift.xcodeproj",
"identifier" : "D8269A38274C095E00BD5BD5",
Expand Down
4 changes: 2 additions & 2 deletions Plans/tvOS-Swift_Base.xctestplan
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
}
],
"defaultOptions" : {
"codeCoverage" : false,
"codeCoverage" : true,
"targetForVariableExpansion" : {
"containerPath" : "container:tvOS-Swift.xcodeproj",
"identifier" : "7BA61D61247FA32600C130A8",
Expand All @@ -21,7 +21,7 @@
{
"target" : {
"containerPath" : "container:tvOS-Swift.xcodeproj",
"identifier" : "7B64388526A6C71A000D0F65",
"identifier" : "1A9FD4374E53BEB8AC621B3D",
Copy link
Member

@philprime philprime Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this identifier change?

Copy link
Member Author

@armcknight armcknight Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that when I created the separate test plan for tvOS-SBSwift in fb7eac9, I simply copied it and only changed the name of the project, but not the identifier there, and since it's supposed to be unique, Xcode changed this one.

"name" : "tvOS-Swift-UITests"
}
}
Expand Down
Loading