Skip to content

Conversation

@armcknight
Copy link
Member

I made the change requested in #5236 (comment) but didn't do this one thing correctly, which failed all the lint steps. However, I'd previously enabled auto-merge, so it merged anyways 😭

#skip-changelog

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.883%. Comparing base (1e92222) to head (83343d8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5245       +/-   ##
=============================================
- Coverage   92.904%   92.883%   -0.021%     
=============================================
  Files          683       683               
  Lines        85882     85876        -6     
  Branches     31150     31139       -11     
=============================================
- Hits         79788     79765       -23     
- Misses        5993      6008       +15     
- Partials       101       103        +2     

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e92222...83343d8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.08 ms 1241.63 ms 21.55 ms
Size 23.76 KiB 819.49 KiB 795.73 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
596ccc1 1230.85 ms 1244.24 ms 13.39 ms
f0ce81c 1231.06 ms 1244.79 ms 13.73 ms
4d3df92 1244.08 ms 1249.84 ms 5.76 ms
6ccaa36 1240.39 ms 1254.80 ms 14.41 ms
07b120c 1225.53 ms 1247.20 ms 21.67 ms
4f31f66 1228.36 ms 1244.57 ms 16.21 ms
1e92222 1226.16 ms 1245.78 ms 19.61 ms
f96d41a 1217.69 ms 1232.44 ms 14.74 ms
5269d20 1230.18 ms 1252.64 ms 22.46 ms
a6f8b18 1238.54 ms 1265.56 ms 27.02 ms

App size

Revision Plain With Sentry Diff
596ccc1 22.84 KiB 401.44 KiB 378.60 KiB
f0ce81c 21.58 KiB 418.33 KiB 396.75 KiB
4d3df92 22.85 KiB 413.45 KiB 390.60 KiB
6ccaa36 21.58 KiB 714.45 KiB 692.87 KiB
07b120c 21.58 KiB 614.90 KiB 593.32 KiB
4f31f66 21.58 KiB 682.40 KiB 660.82 KiB
1e92222 23.76 KiB 819.49 KiB 795.72 KiB
f96d41a 21.58 KiB 616.79 KiB 595.21 KiB
5269d20 21.58 KiB 714.41 KiB 692.83 KiB
a6f8b18 20.76 KiB 431.87 KiB 411.11 KiB

@armcknight armcknight merged commit 5444545 into main May 16, 2025
73 of 79 checks passed
@armcknight armcknight deleted the armcknight/fix/lint-breakage-feedback-api branch May 16, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants