-
-
Notifications
You must be signed in to change notification settings - Fork 237
fix(build): Allow clearing string arguments to build upload
#2946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
build upload
33882a2 to
ef2d2b3
Compare
### Description Don't serialize empty-string values for `--vcs-provider`, `--head-repo-name`, `--head-ref`, `--base-ref`, and `--base-repo-name` into HTTP requests to the assemble build artifact endpoint. This allows users to set these values to empty strings to override any default values. ### Issues - Resolves #2941 - Resolves [CLI-224](https://linear.app/getsentry/issue/CLI-224/skip-serializing-certain-fields-for-build-upload)
ef2d2b3 to
3a116c1
Compare
|
@runningcode, I did not make it possible to clear |
d26e21d to
9760a73
Compare
### Description Don't serialize empty-string values for `--vcs-provider`, `--head-repo-name`, `--head-ref`, `--base-ref`, and `--base-repo-name` into HTTP requests to the assemble build artifact endpoint. This allows users to set these values to empty strings to override any default values. ### Issues - Resolves #2941 - Resolves [CLI-224](https://linear.app/getsentry/issue/CLI-224/skip-serializing-certain-fields-for-build-upload)
9760a73 to
a2cef20
Compare
3a116c1 to
f99509f
Compare
|
Thanks! I'm sure we'll get a bug report one day about clearing the PR number but we can fix it then. It's currently only automatically inferred in Github actions. |

Description
Don't serialize empty-string values for
--vcs-provider,--head-repo-name,--head-ref,--base-ref, and--base-repo-nameinto HTTP requests to the assemble build artifact endpoint. This allows users to set these values to empty strings to override any default values.Issues
build upload#2941