ref(build): Add client-side validation for SHA fields #2945
+157
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/validate-shas
branch
from
605f074 to
a8ffcd4
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 11, 2025
### Description Add client-side validation for SHA fields. Also, don't send these fields' values if the user overrides them with an empty string like `--head-sha ""`. ### Issues - Resolves #2941 - Resolves [CLI-224](https://linear.app/getsentry/issue/CLI-224/skip-serializing-certain-fields-for-build-upload)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/validate-shas
branch
from
a8ffcd4 to
f23e55c
Compare
runningcode
approved these changes
Nov 12, 2025
Contributor
runningcode
left a comment
runningcode
left a comment
There was a problem hiding this comment.
This looks great as is! We also want to be able to empty the other auto-inferred params like vcs-provider, base-ref, head-ref, repo-name, and pr-number.
Member
Author
Aha, got it, I can probably fix that as well (should be simpler; I'll just add the clearing ability without validation for those) |
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 12, 2025
Add client-side validation for SHA fields. Also, don't send these fields' values if the user overrides them with an empty string like `--head-sha ""`. - Resolves #2941 - Resolves [CLI-224](https://linear.app/getsentry/issue/CLI-224/skip-serializing-certain-fields-for-build-upload)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/validate-shas
branch
from
f23e55c to
d26e21d
Compare
loewenheim
approved these changes
Nov 12, 2025
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 12, 2025
Add client-side validation for SHA fields. Also, don't send these fields' values if the user overrides them with an empty string like `--head-sha ""`. - Resolves #2941 - Resolves [CLI-224](https://linear.app/getsentry/issue/CLI-224/skip-serializing-certain-fields-for-build-upload)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/validate-shas
branch
from
d26e21d to
9760a73
Compare
### Description Add client-side validation for SHA fields. Also, don't send these fields' values if the user overrides them with an empty string like `--head-sha ""`. ### Issues - Ref #2941 - Ref [CLI-224](https://linear.app/getsentry/issue/CLI-224/skip-serializing-certain-fields-for-build-upload)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/validate-shas
branch
from
9760a73 to
a2cef20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add client-side validation for SHA fields. Also, don't send these fields' values if the user overrides them with an empty string like
--head-sha "".Issues
build upload#2941