ref(build): Use VcsInfo directly in ChunkedBuildRequest
#2943
+14
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 11, 2025
szokeasaurusrex
changed the title
serde(flatten to include VcsInfo in ChunkedBuildRequestserde(flatten) to include VcsInfo in ChunkedBuildRequest
szokeasaurusrex
changed the title
serde(flatten) to include VcsInfo in ChunkedBuildRequestVcsInfo directly in ChunkedBuildRequest
### Description `serde(flatten)` tells serde to directly serialize these fields into the same level as the rest of the struct, without any nesting. That way, we don't need to redefine all the VCS fields on `ChunkedBuildRequest`.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/simplify_vcs_serialization
branch
from
0be90db to
f303fd4
Compare
runningcode
approved these changes
Nov 12, 2025
Contributor
runningcode
left a comment
runningcode
left a comment
There was a problem hiding this comment.
nice simplification!
loewenheim
approved these changes
Nov 12, 2025
szokeasaurusrex
deleted the
szokeasaurusrex/simplify_vcs_serialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
serde(flatten)tells serde to directly serialize these fields into the same level as the rest of the struct, without any nesting. That way, we don't need to redefine all the VCS fields onChunkedBuildRequest.