UnboundLocalError exception in nikola deploy

[hiway]

Environment

Python Version:

Python 3.7.9

Nikola Version:

Nikola v8.1.2 (installed from git master)

Operating System:

FreeBSD 12.2-RELEASE amd64

Description:

On running nikola deploy on a new site, after rsync completes, this exception is thrown:

  File "[...]/nikola/nikola/plugins/command/deploy.py", line 99, in _execute
    self._emit_deploy_event(last_deploy, new_deploy, clean, undeployed_posts)
UnboundLocalError: local variable 'clean' referenced before assignment

I looked at the source and noticed that clean is only set inside a condition:

nikola/nikola/plugins/command/deploy.py

Lines 50 to 56 in d0ef5b6

	def _execute(self, command, args):
	"""Execute the deploy command."""
	# Get last-deploy from persistent state
	last_deploy = self.site.state.get('last_deploy')
	if last_deploy is not None:
	last_deploy = dateutil.parser.parse(last_deploy)
	clean = False

To try and fix it, I changed the source to:

        if last_deploy is not None:
            last_deploy = dateutil.parser.parse(last_deploy)
            clean = False
        else:
            clean = True

That leads to another exception elsewhere:

  File "[...]/nikola/nikola/plugins/command/deploy.py", line 131, in _emit_deploy_event
    if last_deploy.tzinfo is None:
AttributeError: 'NoneType' object has no attribute 'tzinfo'

Which was fixed by changing the source code at:

nikola/nikola/plugins/command/deploy.py

Lines 98 to 99 in d0ef5b6

	new_deploy = datetime.utcnow()
	self._emit_deploy_event(last_deploy, new_deploy, clean, undeployed_posts)

to:

        new_deploy = datetime.utcnow()
        if last_deploy is None:
            last_deploy = new_deploy
        self._emit_deploy_event(last_deploy, new_deploy, clean, undeployed_posts)

After this the deploy command has worked as I expected.

[dvzrv]

It would be awesome to see this fix in a bugfix release :)

[kayhayen]

If I am not mistaken, there is no such bug fix release, does anyone happen to know which was the last release that didn't have this regression? I would downgrade to that.

[Kwpolska]

I just released Nikola v8.1.3 with the fix for this.