Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #3479 #3480

Merged
merged 1 commit into from
Dec 5, 2020
Merged

fixes #3479 #3480

merged 1 commit into from
Dec 5, 2020

Conversation

hiway
Copy link
Contributor

@hiway hiway commented Dec 2, 2020 •
edited
Loading

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

Fixes UnboundLocalError for clean in the deploy command.

This exposes another related issue where last_deploy is None and passed to _emit_deploy_event,
which throws the exception: AttributeError: 'NoneType' object has no attribute 'tzinfo'

This issue affects new sites where the last_deploy is not yet set.

Issue is at: #3479

@Kwpolska Kwpolska merged commit 1579ff7 into getnikola:master Dec 5, 2020
@Kwpolska
Copy link
Member

Kwpolska commented Dec 5, 2020

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiway @Kwpolska