Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starters): add starter magicsoup.io #11670

Merged
merged 12 commits into from
Feb 13, 2019
Merged

feat(starters): add starter magicsoup.io #11670

merged 12 commits into from
Feb 13, 2019

Conversation

simonfranzen
Copy link
Contributor

Features

Starter includes Optimized images, SEO friendly, Google Webmaster Tools, Responsive UI, Static content with JSON and Markdown, Convert Markdown to StyledComponents, Webfonts, SSR, Testing

@simonfranzen simonfranzen requested a review from a team February 9, 2019 23:38
@simonfranzen
Copy link
Contributor Author

simonfranzen commented Feb 9, 2019

Hey, I have no idea why it fails. I had some problems with characters in wrong encoding, but every validator is telling me that my yml is valid. The error is something with gatsby-starter-blog but I dont have any dependency with that.

And it cant find gatsby on circleci? error There was a problem loading the local build command. Gatsby may not be installed. Perhaps you need to run "npm install"?

Thank you

Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some feedback, thanks so much for the PR!

docs/starters.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@DSchau DSchau changed the title Add starter magicsoup.io feat(starters): add starter magicsoup.io Feb 13, 2019
@DSchau DSchau merged commit 8f7f8cd into gatsbyjs:master Feb 13, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 13, 2019

Holy buckets, @simonfranzen — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

gurpreet-hanjra pushed a commit to gurpreet-hanjra/gatsby that referenced this pull request Feb 14, 2019
## Features

Starter includes Optimized images, SEO friendly, Google Webmaster Tools, Responsive UI, Static content with JSON and Markdown, Convert Markdown to StyledComponents, Webfonts, SSR, Testing
m-allanson added a commit to gurpreet-hanjra/gatsby that referenced this pull request Feb 15, 2019
* master: (76 commits)
  chore(release): Publish
  Update relay version once again (gatsbyjs#11767)
  Update CHANGELOG.md (gatsbyjs#11764)
  chore(release): Publish
  Move to @gatsbyjs scoped version of yarn (gatsbyjs#11759)
  fix(blog): 2019-01-01 json code blocks (gatsbyjs#11750)
  fix(starters): update dependency gatsby to ^2.1.0 (gatsbyjs#11745)
  fix(starters): update dependency prop-types to ^15.7.2 (gatsbyjs#11748)
  feat(showcase): add Incremental.com.au (gatsbyjs#11729)
  feat(starters): add starter magicsoup.io (gatsbyjs#11670)
  docs(gatsby): Add documentation for useStaticQuery (gatsbyjs#11741)
  chore(release): Publish
  feat(gatsby): add useStaticQuery hook (gatsbyjs#11588)
  chore(release): Publish
  chore(docs): reword CSS in JS docs for clarity (gatsbyjs#11439)
  chore: Upgrade Prettier related packages to the latest (gatsbyjs#11735)
  fix(core): added event source polyfill in develop to fix IE/edge hmr (gatsbyjs#11582)
  chore: minify svg husky hook (gatsbyjs#10560)
  docs: add videos for Gatsby Link + rewrite for flow (gatsbyjs#11700)
  docs: add egghead lesson to quickstart (gatsbyjs#11699)
  ...
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
## Features

Starter includes Optimized images, SEO friendly, Google Webmaster Tools, Responsive UI, Static content with JSON and Markdown, Convert Markdown to StyledComponents, Webfonts, SSR, Testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants