Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): reword CSS in JS docs for clarity #11439

Merged
merged 3 commits into from
Feb 13, 2019
Merged

Conversation

gurpreet-hanjra
Copy link
Contributor

@gurpreet-hanjra gurpreet-hanjra commented Jan 31, 2019

Description

Gives clear info about installation of libraries, helpers and gatsby plugins. Adds review comments from emotion docs.

Related Issues

@gurpreet-hanjra gurpreet-hanjra requested a review from a team January 31, 2019 16:02
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I left a couple of comments inline.

docs/docs/glamor.md Outdated Show resolved Hide resolved
docs/docs/styled-components.md Outdated Show resolved Hide resolved
@gurpreet-hanjra
Copy link
Contributor Author

Hello, @marcysutton please review :)

@gurpreet-hanjra gurpreet-hanjra added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Feb 11, 2019
@DSchau DSchau changed the title Rewording for clear installation of styling libs, complies with emotion chore(docs): reword CSS in JS docs for clarity Feb 13, 2019
@DSchau DSchau merged commit 0caea8b into master Feb 13, 2019
@DSchau DSchau deleted the docs/rewording_styling branch February 13, 2019 16:18
gurpreet-hanjra added a commit to gurpreet-hanjra/gatsby that referenced this pull request Feb 14, 2019
<!--
  Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

Gives clear info about installation of libraries, helpers and gatsby plugins. Adds review comments from emotion docs.

## Related Issues

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc.
-->
m-allanson added a commit to gurpreet-hanjra/gatsby that referenced this pull request Feb 15, 2019
* master: (76 commits)
  chore(release): Publish
  Update relay version once again (gatsbyjs#11767)
  Update CHANGELOG.md (gatsbyjs#11764)
  chore(release): Publish
  Move to @gatsbyjs scoped version of yarn (gatsbyjs#11759)
  fix(blog): 2019-01-01 json code blocks (gatsbyjs#11750)
  fix(starters): update dependency gatsby to ^2.1.0 (gatsbyjs#11745)
  fix(starters): update dependency prop-types to ^15.7.2 (gatsbyjs#11748)
  feat(showcase): add Incremental.com.au (gatsbyjs#11729)
  feat(starters): add starter magicsoup.io (gatsbyjs#11670)
  docs(gatsby): Add documentation for useStaticQuery (gatsbyjs#11741)
  chore(release): Publish
  feat(gatsby): add useStaticQuery hook (gatsbyjs#11588)
  chore(release): Publish
  chore(docs): reword CSS in JS docs for clarity (gatsbyjs#11439)
  chore: Upgrade Prettier related packages to the latest (gatsbyjs#11735)
  fix(core): added event source polyfill in develop to fix IE/edge hmr (gatsbyjs#11582)
  chore: minify svg husky hook (gatsbyjs#10560)
  docs: add videos for Gatsby Link + rewrite for flow (gatsbyjs#11700)
  docs: add egghead lesson to quickstart (gatsbyjs#11699)
  ...
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
<!--
  Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or
  ask in this Pull Request and a Gatsby maintainer will be happy to help :)
-->

## Description

Gives clear info about installation of libraries, helpers and gatsby plugins. Adds review comments from emotion docs.

## Related Issues

<!--
  Link to the issue that is fixed by this PR (if there is one)
  e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants