fix(core): added event source polyfill in develop to fix IE/edge hmr #11582
Conversation
There was a problem hiding this comment.
Fixed the lint changes, so this looks good.
@saranshkataria were you able to validate this solves the issue for Internet Explorer/Windows? If you need any assistance with that, I'd recommend checking out gatsby-dev-cli, which lets you link a local version of Gatsby within a project.
|
I tried using gatsby-dev-cli, but was not able to, but do not see the event source plugin hooked up when I run it. I am not sure if I am missing something while setting up gatsby-dev-cli or I missed some statement while importing the polyfill. I looked for some implementations in other projects, they have added the same files that I added, but I cannot get it working for me somehow. Would need some help on how to proceed further. |
|
Yeah, |
|
@pieh already did that, but still, IE throws the warning that event source is missing |
|
I will take a look at it tomorrow |
|
@pieh did you get a chance to look into it? |
|
I did not - I keep doing too many TO-DOs to complete them all :( |
|
@pieh I'll check this one :) |
wardpeet
changed the title
…atsbyjs#11582) fixes gatsbyjs#11495 ## Description Added event source polyfill in develop mode for IE. I am not sure how to test the CLI after making these changes, would need some pointers for that. Co-authored-by: Dustin Schau <[email protected]>
* master: (76 commits) chore(release): Publish Update relay version once again (gatsbyjs#11767) Update CHANGELOG.md (gatsbyjs#11764) chore(release): Publish Move to @gatsbyjs scoped version of yarn (gatsbyjs#11759) fix(blog): 2019-01-01 json code blocks (gatsbyjs#11750) fix(starters): update dependency gatsby to ^2.1.0 (gatsbyjs#11745) fix(starters): update dependency prop-types to ^15.7.2 (gatsbyjs#11748) feat(showcase): add Incremental.com.au (gatsbyjs#11729) feat(starters): add starter magicsoup.io (gatsbyjs#11670) docs(gatsby): Add documentation for useStaticQuery (gatsbyjs#11741) chore(release): Publish feat(gatsby): add useStaticQuery hook (gatsbyjs#11588) chore(release): Publish chore(docs): reword CSS in JS docs for clarity (gatsbyjs#11439) chore: Upgrade Prettier related packages to the latest (gatsbyjs#11735) fix(core): added event source polyfill in develop to fix IE/edge hmr (gatsbyjs#11582) chore: minify svg husky hook (gatsbyjs#10560) docs: add videos for Gatsby Link + rewrite for flow (gatsbyjs#11700) docs: add egghead lesson to quickstart (gatsbyjs#11699) ...
…atsbyjs#11582) fixes gatsbyjs#11495 ## Description Added event source polyfill in develop mode for IE. I am not sure how to test the CLI after making these changes, would need some pointers for that. Co-authored-by: Dustin Schau <[email protected]>
fixes #11495
Description
Added event source polyfill in develop mode for IE. I am not sure how to test the CLI after making these changes, would need some pointers for that.