Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change base image to distroless #62

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Change base image to distroless #62

merged 3 commits into from
Jul 5, 2022

Conversation

kon-angelo
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Use distroless base image

@kon-angelo kon-angelo requested review from a team as code owners July 1, 2022 17:10
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 1, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 1, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 1, 2022
@kon-angelo
Copy link
Contributor Author

/reviewed ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2022
@himanshu-kun
Copy link
Contributor

oci_image step is failing @kon-angelo

@kon-angelo
Copy link
Contributor Author

/squash

@gardener-robot gardener-robot added the merge/squash Should be merged via 'Squash and merge' label Jul 4, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2022
@kon-angelo
Copy link
Contributor Author

@himanshu-kun PTAL :)

himanshu-kun
himanshu-kun reviewed Jul 4, 2022
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use gcr.io/distroless/base:latest ?

@kon-angelo
Copy link
Contributor Author

I am not a fan of using latest, since these are not really reproducable builds. As for the choice of base image, I used this as reference gardener/gardener-extension-provider-gcp#456 since we already had updated our base images in the other repos and used the same here.

@kon-angelo
Copy link
Contributor Author

Diving a bit into the differences between them, based on https://github.com/GoogleContainerTools/distroless/blob/main/base/README.md, the static variants are more minimal than base and we definitely don't need the glibc fluff.

@himanshu-kun
Copy link
Contributor

Diving a bit into the differences between them, based on https://github.com/GoogleContainerTools/distroless/blob/main/base/README.md, the static variants are more minimal than base and we definitely don't need the glibc fluff.

Okay, thanks for pointing out the differences.

himanshu-kun
himanshu-kun approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Do you suggest to do the same for other providers also?

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 5, 2022
@kon-angelo
Copy link
Contributor Author

@himanshu-kun yes, I think we should go distroless for all our images if possible.

@kon-angelo kon-angelo merged commit 4bf4936 into gardener:master Jul 5, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 5, 2022
@kon-angelo kon-angelo deleted the distroless branch July 5, 2022 08:58
This was referenced Jul 14, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

Assignees
No one assigned
Labels
merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kon-angelo @himanshu-kun @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot