Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change base image from alpine to distroless #31

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Change base image from alpine to distroless #31

merged 1 commit into from
Jul 25, 2022

Conversation

ialidzhikov
Copy link
Member

/area security
/kind enhancement

What this PR does / why we need it:
Similar to gardener/machine-controller-manager-provider-openstack#62

Release note:

machine-controller-manager-provider-alicloud now uses `distroless` instead of `alpine` as a base image.

@ialidzhikov ialidzhikov requested review from a team as code owners July 14, 2022 11:21
@gardener-robot gardener-robot added area/security Security related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 14, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 14, 2022
himanshu-kun
himanshu-kun approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 15, 2022
@himanshu-kun himanshu-kun added the needs/second-opinion Needs second review by someone else label Jul 15, 2022
@gardener-robot gardener-robot removed the reviewed/lgtm Has approval for merging label Jul 15, 2022
@shaoyongfeng shaoyongfeng merged commit b840a2e into gardener:master Jul 25, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 25, 2022
@ialidzhikov ialidzhikov deleted the enh/distroless branch July 25, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

Assignees
No one assigned
Labels
area/security Security related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @shaoyongfeng @himanshu-kun @gardener-robot-ci-2 @gardener-robot